Merged
Conversation
|
✔️ Deploy Preview for sb-apprentices ready! 🔨 Explore the source changes: a38f8d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/sb-apprentices/deploys/617c264ffdd3a50007dd4332 😎 Browse the preview: https://deploy-preview-13--sb-apprentices.netlify.app |
auaruss
force-pushed
the
feat--add-apprentice-qualities
branch
3 times, most recently
from
59ae2c6 to
ca3ee97
Compare
jonoliver
reviewed
Oct 29, 2021
| @@ -0,0 +1,114 @@ | |||
| $c-highlight-green: #01F5AC; | |||
|
|
|||
| // TODO: make padding 2 on both sides a global variable | |||
Member
There was a problem hiding this comment.
Hey Alice, is this something you intended to address in this PR?
Contributor
Author
There was a problem hiding this comment.
Fixed, will be addressed in a future card.
auaruss
force-pushed
the
feat--add-apprentice-qualities
branch
from
d843b9f to
a38f8d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ApprenticeQualities component.
Spec
Designs: [https://www.figma.com/file/eeSQQIRz0R5Ag9SIJJH6Hx/apprentices.sparkbox.com?node-id=104%3A7330]
See Story: FSA21V2-143
To Test
npm run test:ci[For an example of good validation instructions, check out Bryan's Bouncy Ball PR.]
Validation
The following has been completed by the developer:
[delete anything irrelevant to this PR]
Browser Testing
[delete if irrelevant to this issue]
Gold Level Browsers
In these browsers, all content is accessible and design matches exactly. In most cases, bugs should be resolved before merge.
macOS
Windows
Mobile
Silver Level Browsers
In these browsers, all content is readable, but design may be inaccurate.
Windows
Mobile
Bronze Level Browsers
In these browsers, our only goal is content readability.
Windows