Redesign/review scotch #305
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -918,7 +918,7 @@ | |
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").NotificationRequest" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -936,7 +936,7 @@ | |
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").FCMNotificationRequest" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -963,7 +963,7 @@ | |
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").UserNotification" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -992,7 +992,7 @@ | |
| "schema": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/agreement/domain/UserAgreement\").Agreement" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -1010,7 +1010,7 @@ | |
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").Notification" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -1035,7 +1035,7 @@ | |
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").Notification" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -1087,7 +1087,7 @@ | |
| "schema": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").Notification" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -1110,7 +1110,7 @@ | |
| "type": "null" | ||
| }, | ||
| { | ||
| "$ref": "#/components/schemas/import(\"/Users/panda/Desktop/develop/sparcs/otlplus-server/apps/server/src/modules/notification/domain/notification\").Notification" | ||
| } | ||
| ] | ||
| } | ||
|
|
@@ -2660,6 +2660,80 @@ | |
| } | ||
| } | ||
| }, | ||
| "/api/v2/reviews/{reviewId}": { | ||
| "put": { | ||
| "summary": "ReviewsV2Controller.updateReviewV2", | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/IReviewV2.UpdateResponseDto" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "name": "reviewId", | ||
| "in": "path", | ||
| "required": true, | ||
| "schema": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| ], | ||
| "requestBody": { | ||
| "required": true, | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/IReviewV2.UpdateDto" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/api/v2/reviews/{reviewId}/liked": { | ||
| "patch": { | ||
| "summary": "ReviewsV2Controller.patchReviewLike", | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/IReviewV2.UpdateResponseDto" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "name": "reviewId", | ||
| "in": "path", | ||
| "required": true, | ||
| "schema": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| ], | ||
| "requestBody": { | ||
| "required": true, | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/IReviewV2.PatchLikedDto" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/api/v2/timetables": { | ||
| "get": { | ||
| "summary": "TimetablesControllerV2.getTimetables", | ||
|
|
@@ -6240,9 +6314,6 @@ | |
| "direction": { | ||
| "type": "string", | ||
| "enum": ["ltr", "rtl"] | ||
| } | ||
| }, | ||
| "required": [ | ||
|
|
@@ -6269,8 +6340,7 @@ | |
| "textBaseline", | ||
| "textAlign", | ||
| "canvas", | ||
| "direction" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
|
|
@@ -7702,6 +7772,56 @@ | |
| "required": ["lectureId", "content", "grade", "load", "speech"] | ||
| }, | ||
| "IReviewV2.CreateResponseDto": {}, | ||
| "IReviewV2.UpdateDto": { | ||
| "properties": { | ||
| "content": { | ||
| "minLength": 1, | ||
| "type": "string" | ||
| }, | ||
| "grade": { | ||
| "maximum": 5, | ||
| "type": "number", | ||
| "minimum": 0 | ||
| }, | ||
| "load": { | ||
| "maximum": 5, | ||
| "type": "number", | ||
| "minimum": 0 | ||
| }, | ||
| "speech": { | ||
| "maximum": 5, | ||
| "type": "number", | ||
| "minimum": 0 | ||
| } | ||
| }, | ||
| "type": "object", | ||
| "required": ["content", "grade", "load", "speech"] | ||
| }, | ||
| "IReviewV2.UpdateResponseDto": { | ||
| "properties": { | ||
| "id": { | ||
| "minLength": 1, | ||
| "type": "number" | ||
|
Comment on lines
+7803
to
+7804
There was a problem hiding this comment. The |
||
| } | ||
| }, | ||
| "type": "object", | ||
| "required": ["id"] | ||
| }, | ||
| "IReviewV2.PatchLikedDto": { | ||
| "properties": { | ||
| "reviewId": { | ||
| "minLength": 1, | ||
| "type": "number" | ||
|
Comment on lines
+7813
to
+7814
There was a problem hiding this comment. The |
||
| }, | ||
| "action": { | ||
| "type": "string", | ||
| "enum": ["like", "unlike"], | ||
| "minLength": 1 | ||
| } | ||
| }, | ||
| "type": "object", | ||
| "required": ["reviewId", "action"] | ||
| }, | ||
| "ITimetableV2.GetListQueryDto": { | ||
| "properties": { | ||
| "user_id": { | ||
paisano55 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||||||||
| import { | ||||||||||||
| Body, Controller, Get, HttpException, HttpStatus, Param, Patch, Post, Put, Query, Req, | ||||||||||||
| } from '@nestjs/common' | ||||||||||||
| import { GetLanguage } from '@otl/server-nest/common/decorators/get-language.decorator' | ||||||||||||
| import { GetUser } from '@otl/server-nest/common/decorators/get-user.decorator' | ||||||||||||
|
|
@@ -48,4 +48,29 @@ export class ReviewsV2Controller { | |||||||||||
| const result = await this.reviewsV2Service.createReviewV2(reviewBody, user) | ||||||||||||
| return { id: result.id } | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| @Put('/:reviewId') | ||||||||||||
| async updateReviewV2( | ||||||||||||
| @Param('reviewId') reviewId: number, | ||||||||||||
| @Body() reviewBody: IReviewV2.UpdateDto, | ||||||||||||
| @GetUser() user: session_userprofile, | ||||||||||||
| ): Promise<IReviewV2.UpdateResponseDto> { | ||||||||||||
| if (!user) { | ||||||||||||
| throw new HttpException('Unauthorized', HttpStatus.UNAUTHORIZED) | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| return await this.reviewsV2Service.updateReviewV2(reviewId, reviewBody, user) | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| @Patch('/:reviewId/liked') | ||||||||||||
| async patchReviewLike( | ||||||||||||
| @Param('reviewId') reviewId: number, | ||||||||||||
| @Body() body: IReviewV2.PatchLikedDto, | ||||||||||||
| @GetUser() user: session_userprofile, | ||||||||||||
| ): Promise<IReviewV2.UpdateResponseDto> { | ||||||||||||
| if (reviewId !== body.reviewId) { | ||||||||||||
| throw new HttpException('Path param and body id not match', HttpStatus.BAD_REQUEST) | ||||||||||||
| } | ||||||||||||
| return await this.reviewsV2Service.updateReviewLiked(body, user) | ||||||||||||
|
Comment on lines
+71
to
+74
There was a problem hiding this comment. The reviewId is redundantly specified in both the path parameter and request body. Consider removing reviewId from PatchLikedDto since it's already available in the URL path, which would eliminate the need for this validation check.
Suggested change
|
||||||||||||
| } | ||||||||||||
| } | ||||||||||||
|
There was a problem hiding this comment. 이 코드 패치에 대해 몇 가지 잠재적 버그 및 개선 사항을 지적하겠습니다.
위 사항들을 고려하여 코드를 개선하는 것이 좋습니다. |
||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema references contain absolute file paths that are specific to a developer's local machine. These should use relative paths or symbolic references to ensure the Swagger documentation works consistently across different development environments.