refactor(config): simplify env var expansion to pre-parse approach#164
Merged
spachava753 merged 1 commit intomainfrom Feb 2, 2026
Merged
refactor(config): simplify env var expansion to pre-parse approach#164spachava753 merged 1 commit intomainfrom
spachava753 merged 1 commit intomainfrom
Conversation
Environment variable expansion now happens on the raw config file content before YAML/JSON parsing, rather than post-parse on specific struct fields. This provides universal env var support throughout the entire config file using os.ExpandEnv().
The previous implementation required manually expanding env vars in each supported field, which was error-prone when adding new config fields and limited flexibility. The new approach expands $VAR and ${VAR} syntax anywhere in the config, including map keys, array elements, and nested values.
Added error hints when parsing fails after expansion to help users diagnose issues caused by special characters in env var values. Updated documentation with caveats about YAML/JSON special characters and the lack of escape syntax for literal $ signs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors environment variable expansion in the config system from a post-parse struct method to pre-parse text expansion using os.ExpandEnv().
Changes
Benefits
Testing
All config tests pass. Added edge case tests for: