[Merged by Bors] - Syntactical validation of merged ATXs #6030

poszu · 2024-06-11T14:22:43Z

Motivation

Closes #5997

Support handling merged ATXs. Only syntactical validation.

Description

Test Plan

unit tests
an E2E test that:
- marries 2 IDs
- publishes a merged ATX signed by ID0
- publishes a merged ATX signed by ID1
- executes emergency split and publishes 2 ATX, each ID seperately

TODO

Explain motivation or link existing issue(s)
Test changes and document test plan
Update documentation as needed
Update changelog as needed

codecov · 2024-06-11T14:43:11Z

Codecov Report

Attention: Patch coverage is 84.36658% with 58 lines in your changes missing coverage. Please review.

Project coverage is 81.6%. Comparing base (9a01a6c) to head (ec6e1d5).
Report is 2 commits behind head on develop.

Files	Patch %	Lines
sql/migrations/state_0021_migration.go	67.7%	18 Missing and 11 partials ⚠️
activation/handler_v2.go	91.3%	6 Missing and 5 partials ⚠️
sql/atxs/atxs.go	87.0%	4 Missing and 3 partials ⚠️
activation/handler_v1.go	50.0%	3 Missing and 3 partials ⚠️
sql/identities/identities.go	90.4%	2 Missing and 2 partials ⚠️
activation/wire/challenge_v2.go	0.0%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #6030    +/-   ##
========================================
  Coverage     81.6%   81.6%            
========================================
  Files          301     302     +1     
  Lines        32260   32454   +194     
========================================
+ Hits         26328   26488   +160     
- Misses        4214    4234    +20     
- Partials      1718    1732    +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

poszu · 2024-06-13T11:04:45Z

bors try

spacemesh-bors · 2024-06-13T11:39:48Z

try

Build failed:

ci-status

activation/wire/wire_v2.go

activation/handler_v2.go

poszu · 2024-06-20T11:51:04Z

Bors try

spacemesh-bors · 2024-06-20T12:38:17Z

try

Build succeeded:

activation/handler_v2.go

activation/wire/wire_v2.go

poszu · 2024-06-21T09:12:10Z

bors try

spacemesh-bors · 2024-06-21T09:54:30Z

try

Build failed:

systest-status

poszu · 2024-06-21T11:32:59Z

grpc errors...

bors try

spacemesh-bors · 2024-06-21T12:18:17Z

try

Build failed:

systest-status

activation/e2e/atx_merge_test.go

sql/atxs/atxs.go

activation/handler_v2.go

activation/handler_v2_test.go

sql/migrations/state_0021_migration.go

…tactical-validation-merged

poszu · 2024-07-04T10:05:14Z

bors merge

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors · 2024-07-04T11:03:13Z

Build failed:

systest-status

poszu · 2024-07-04T11:22:15Z

bors merge

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors · 2024-07-04T12:29:40Z

Build failed:

systest-status

poszu · 2024-07-04T12:47:03Z

bors merge

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors · 2024-07-04T13:51:14Z

Build failed:

ci-status

poszu · 2024-07-04T13:58:43Z

bors merge

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors · 2024-07-04T14:50:18Z

Pull request successfully merged into develop.

Build succeeded:

poszu requested review from dshulyak, fasmat and ivan4th as code owners June 11, 2024 14:22

poszu force-pushed the atx-handler-v2/syntactical-validation-merged branch from 38d3bd4 to 9d08779 Compare June 11, 2024 14:25

spacemesh-bors bot added a commit that referenced this pull request Jun 13, 2024

Try #6030:

2808d81

fasmat reviewed Jun 13, 2024

View reviewed changes

activation/wire/wire_v2.go Show resolved Hide resolved

activation/handler_v2.go Show resolved Hide resolved

poszu force-pushed the atx-handler-v2/syntactical-validation-merged branch from 0a220fe to ccb7552 Compare June 19, 2024 15:35

spacemesh-bors bot added a commit that referenced this pull request Jun 20, 2024

Try #6030:

fd606fd

fasmat reviewed Jun 20, 2024

View reviewed changes

activation/handler_v2.go Show resolved Hide resolved

activation/handler_v2.go Show resolved Hide resolved

activation/handler_v2.go Outdated Show resolved Hide resolved

activation/handler_v2.go Show resolved Hide resolved

activation/wire/wire_v2.go Show resolved Hide resolved

spacemesh-bors bot changed the base branch from atx-handler-v2/marriages to develop June 20, 2024 16:16

spacemesh-bors bot requested a review from acud as a code owner June 20, 2024 16:16

poszu added 7 commits June 20, 2024 18:21

Syntactical validation of merged ATX

8263c09

Test publishing merged ATX by another ID

4371095

Allow sharing nipostchallenge in merged ATX

6414f3d

Test emergency split

b51d401

Marry using reference ATX from the same epoch

29301a2

Calculate and persist ATX weight in DB

7d0e2c6

Review feedback

72f8ec3

poszu force-pushed the atx-handler-v2/syntactical-validation-merged branch from d203962 to 72f8ec3 Compare June 21, 2024 08:27

spacemesh-bors bot added a commit that referenced this pull request Jun 21, 2024

Try #6030:

398ce1e

spacemesh-bors bot added a commit that referenced this pull request Jun 21, 2024

Try #6030:

50efe68

poszu added 4 commits July 1, 2024 12:27

avoid underflow

a3e7920

small cleanups

8899c8e

increase migration 21 batch size to 1M ATXs

69d7e58

update checkpoint JSON schema

6bf6bd2

fasmat requested changes Jul 1, 2024

View reviewed changes

review feedback

a7089fb

poszu requested a review from fasmat July 2, 2024 12:58

poszu added 4 commits July 2, 2024 15:32

Simpify code around poet membership proof validation

8f09fb4

review feedback

7ec6602

Merge remote-tracking branch 'origin/develop' into atx-handler-v2/syn…

edd549e

…tactical-validation-merged

Fix after merge with develop

eddbd13

fasmat approved these changes Jul 3, 2024

View reviewed changes

poszu added 2 commits July 4, 2024 09:35

small cleanup of test

f7454c3

don't modify released migration

ec6e1d5

poszu force-pushed the atx-handler-v2/syntactical-validation-merged branch from e12a15b to ec6e1d5 Compare July 4, 2024 07:40

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024

Syntactical validation of merged ATXs (#6030)

d15d530

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024

Syntactical validation of merged ATXs (#6030)

2bc5dae

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024

Syntactical validation of merged ATXs (#6030)

72bfa8b

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors bot pushed a commit that referenced this pull request Jul 4, 2024

Syntactical validation of merged ATXs (#6030)

0ec1b2e

## Motivation Closes #5997 Support handling merged ATXs. Only syntactical validation.

spacemesh-bors bot changed the title ~~Syntactical validation of merged ATXs~~ [Merged by Bors] - Syntactical validation of merged ATXs Jul 4, 2024

spacemesh-bors bot closed this Jul 4, 2024

spacemesh-bors bot deleted the atx-handler-v2/syntactical-validation-merged branch July 4, 2024 14:50

[Merged by Bors] - Syntactical validation of merged ATXs #6030

[Merged by Bors] - Syntactical validation of merged ATXs #6030

Uh oh!

Conversation

poszu commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Description

Test Plan

TODO

Uh oh!

codecov bot commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

poszu commented Jun 13, 2024

Uh oh!

spacemesh-bors bot commented Jun 13, 2024

try

Uh oh!

Uh oh!

Uh oh!

poszu commented Jun 20, 2024

Uh oh!

spacemesh-bors bot commented Jun 20, 2024

try

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

poszu commented Jun 21, 2024

Uh oh!

spacemesh-bors bot commented Jun 21, 2024

try

Uh oh!

poszu commented Jun 21, 2024

Uh oh!

spacemesh-bors bot commented Jun 21, 2024

try

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

poszu commented Jul 4, 2024

Uh oh!

spacemesh-bors bot commented Jul 4, 2024

Uh oh!

poszu commented Jul 4, 2024

Uh oh!

spacemesh-bors bot commented Jul 4, 2024

Uh oh!

poszu commented Jul 4, 2024

Uh oh!

spacemesh-bors bot commented Jul 4, 2024

Uh oh!

poszu commented Jul 4, 2024

Uh oh!

spacemesh-bors bot commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

poszu commented Jun 11, 2024 •

edited

Loading

codecov bot commented Jun 11, 2024 •

edited

Loading