Skip to content

Conversation

@eliecharra
Copy link
Member

Description of the change

This add documentation about how to use the new workerpool auto registration feature when using k8s native workers.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@eliecharra eliecharra force-pushed the feat/CU-869av0xyh_Update-documentation-to-describe-feature branch 2 times, most recently from 8fd2085 to 4aaf905 Compare October 23, 2025 09:31
@eliecharra eliecharra force-pushed the feat/CU-869av0xyh_Update-documentation-to-describe-feature branch from 4aaf905 to 316c419 Compare October 23, 2025 09:35
@eliecharra
Copy link
Member Author

@KiraLempereur-Spacelift Would you mind taking a quick look on this one? 🙇🏻

@eliecharra eliecharra force-pushed the feat/CU-869av0xyh_Update-documentation-to-describe-feature branch 4 times, most recently from a3fce5a to 260a554 Compare October 24, 2025 09:11
Copy link
Collaborator

@KiraLempereur-Spacelift KiraLempereur-Spacelift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are looking really good so far, thank you! I've commented some specific wording updates. Let me know if/when you need another review!

eliecharra and others added 2 commits October 27, 2025 10:40
This add documentation about how to use the new workerpool auto
registration feature when using k8s native workers.

Apply suggestion from @adamconnelly

Co-authored-by: Adam Connelly <[email protected]>

Apply suggestion from @adamconnelly

Co-authored-by: Adam Connelly <[email protected]>

Apply suggestion from @adamconnelly

Co-authored-by: Adam Connelly <[email protected]>
@eliecharra eliecharra force-pushed the feat/CU-869av0xyh_Update-documentation-to-describe-feature branch from 619b7ff to 3d985fe Compare October 27, 2025 09:40
@eliecharra eliecharra marked this pull request as ready for review October 27, 2025 09:40
@eliecharra
Copy link
Member Author

Thanks a lot @KiraLempereur-Spacelift , that is your feedbacks fixed.

Copy link
Collaborator

@KiraLempereur-Spacelift KiraLempereur-Spacelift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, next time I'll use the suggestion block for wording changes.

@KiraLempereur-Spacelift KiraLempereur-Spacelift enabled auto-merge (rebase) October 28, 2025 15:53
Added the fedramp "broken link" because it isn't actually broken, to the exclusions of the link checker

- **Account default runner images** — Added support for account default runner images. See the [runtime security](../integrations/docker.md#account-default-runner-images) for more information.

## 2025-10-23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliecharra just adding a reminder here - we'll need to adjust the date (and in the SH version as well) just before merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻


Some release of the controller may include backward compatibility breaks, you can find below instructions about how to upgrade for those specials versions.

### Upgrading to controller v0.0.27 - or Helm chart v0.51.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamconnelly I'm also adding a reminder here since Ilya might release another helm chart version, so we need to check 0.51.0 will still be the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants