-
Notifications
You must be signed in to change notification settings - Fork 20
feat(CU-869av0xyh): add kubernetes auto worker pool registration #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(CU-869av0xyh): add kubernetes auto worker pool registration #939
Conversation
8fd2085 to
4aaf905
Compare
4aaf905 to
316c419
Compare
|
@KiraLempereur-Spacelift Would you mind taking a quick look on this one? 🙇🏻 |
a3fce5a to
260a554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs are looking really good so far, thank you! I've commented some specific wording updates. Let me know if/when you need another review!
This add documentation about how to use the new workerpool auto registration feature when using k8s native workers. Apply suggestion from @adamconnelly Co-authored-by: Adam Connelly <[email protected]> Apply suggestion from @adamconnelly Co-authored-by: Adam Connelly <[email protected]> Apply suggestion from @adamconnelly Co-authored-by: Adam Connelly <[email protected]>
619b7ff to
3d985fe
Compare
|
Thanks a lot @KiraLempereur-Spacelift , that is your feedbacks fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, next time I'll use the suggestion block for wording changes.
…ure' of https://github.com/spacelift-io/user-documentation into feat/CU-869av0xyh_Update-documentation-to-describe-feature
Added the fedramp "broken link" because it isn't actually broken, to the exclusions of the link checker
|
|
||
| - **Account default runner images** — Added support for account default runner images. See the [runtime security](../integrations/docker.md#account-default-runner-images) for more information. | ||
|
|
||
| ## 2025-10-23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliecharra just adding a reminder here - we'll need to adjust the date (and in the SH version as well) just before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
|
||
| Some release of the controller may include backward compatibility breaks, you can find below instructions about how to upgrade for those specials versions. | ||
|
|
||
| ### Upgrading to controller v0.0.27 - or Helm chart v0.51.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamconnelly I'm also adding a reminder here since Ilya might release another helm chart version, so we need to check 0.51.0 will still be the latest.
Description of the change
This add documentation about how to use the new workerpool auto registration feature when using k8s native workers.
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
mainbranch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇