Skip to content

Migrate hand-written signatures into inline RBS comments#32

Merged
soutaro merged 7 commits intosoutaro:mainfrom
tomoasleep:rbs-inlining
May 28, 2024
Merged

Migrate hand-written signatures into inline RBS comments#32
soutaro merged 7 commits intosoutaro:mainfrom
tomoasleep:rbs-inlining

Conversation

@tomoasleep
Copy link
Copy Markdown
Contributor

This PR migrates the hand-written RBS signatures in the sig/rbs directory to inline RBS comments.

For reviewers

In each commit, I have converted the hand-written RBS files to inline RBS comments.
I recommend reviewing each commit separately.

@ParadoxV5
Copy link
Copy Markdown

+1 to eat our own dog food eventually, but because this project is still experimental (even the semantics might still change!), it might be a bit too soon to migrate?

This also reminds me on the pros and cons of checking generated files to Git/Hub.
Uploading them eliminates their setup for development and packaging alike, while a linguist-generated entry solves their pollution in the diffs and statistics.

@soutaro
Copy link
Copy Markdown
Owner

soutaro commented May 23, 2024

@ParadoxV5 Good point. 👍

Dog fooding is more important I think, because the project is not very big so that it won't require huge rewrite anyway.
I'm thinking to keep the generated RBS files checked in, because having the generated code would make some sense for this experimental project.

@soutaro soutaro enabled auto-merge May 28, 2024 08:24
@soutaro soutaro merged commit 1ac68c4 into soutaro:main May 28, 2024
@tomoasleep tomoasleep deleted the rbs-inlining branch May 31, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants