Migrate hand-written signatures into inline RBS comments#32
Merged
soutaro merged 7 commits intosoutaro:mainfrom May 28, 2024
Merged
Migrate hand-written signatures into inline RBS comments#32soutaro merged 7 commits intosoutaro:mainfrom
soutaro merged 7 commits intosoutaro:mainfrom
Conversation
|
+1 to eat our own dog food eventually, but because this project is still experimental (even the semantics might still change!), it might be a bit too soon to migrate? This also reminds me on the pros and cons of checking generated files to Git/Hub. |
Owner
|
@ParadoxV5 Good point. 👍 Dog fooding is more important I think, because the project is not very big so that it won't require huge rewrite anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the hand-written RBS signatures in the sig/rbs directory to inline RBS comments.
For reviewers
In each commit, I have converted the hand-written RBS files to inline RBS comments.
I recommend reviewing each commit separately.