Skip to content

Conversation

@lukeseawalker
Copy link
Contributor

@lukeseawalker lukeseawalker commented Nov 2, 2020

Description

Package will be updated to latest if version is not provided.

Issues Resolved

List any existing issues this PR resolves

Check List

  • [ X ] All tests pass. See TESTING.md for details.
  • [ X ] New functionality includes testing.
  • [ X ] New functionality has been documented in the README if applicable.

@lukeseawalker lukeseawalker requested a review from a team November 2, 2020 11:56
lukeseawalker added a commit to lukeseawalker/aws-parallelcluster-cookbook that referenced this pull request Nov 2, 2020
Don't skip installation if upgrade flag is provided but version it's not

PR reported in sous-chefs/pyenv#78

Signed-off-by: Luca Carrogu <[email protected]>
@ramereth
Copy link
Contributor

ramereth commented Nov 2, 2020

@lukeseawalker can you please address the two issues mentioned by kitchen-porter?

@lukeseawalker lukeseawalker force-pushed the master branch 2 times, most recently from ea48f85 to c550af1 Compare November 3, 2020 08:13
@lukeseawalker lukeseawalker changed the title Don't skip installation if upgrade flag is provided but version it's not Don't skip installation if upgrade flag is provided Nov 3, 2020
@lukeseawalker lukeseawalker force-pushed the master branch 3 times, most recently from 47868cf to 6e78190 Compare November 3, 2020 08:24
@lukeseawalker
Copy link
Contributor Author

lukeseawalker commented Nov 3, 2020

@ramereth I'm not sure about the "Release Label Validator" check, can you please help?

lukeseawalker added a commit to lukeseawalker/aws-parallelcluster-cookbook that referenced this pull request Nov 3, 2020
Don't skip installation if upgrade flag is provided but version it's not

PR reported in sous-chefs/pyenv#78

Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker added a commit to aws/aws-parallelcluster-cookbook that referenced this pull request Nov 3, 2020
Don't skip installation if upgrade flag is provided but version it's not

PR reported in sous-chefs/pyenv#78

Signed-off-by: Luca Carrogu <[email protected]>
@lukeseawalker lukeseawalker force-pushed the master branch 4 times, most recently from b0050ff to 3a5290d Compare November 4, 2020 10:48
@lukeseawalker lukeseawalker changed the title Don't skip installation if upgrade flag is provided Add upgrade action Nov 4, 2020
@lukeseawalker lukeseawalker force-pushed the master branch 8 times, most recently from 9d7b92e to 6440a46 Compare November 4, 2020 12:28
@ramereth ramereth added Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged labels Nov 4, 2020
@ramereth
Copy link
Contributor

ramereth commented Nov 4, 2020

@lukeseawalker can you please update the documentation to reflect this new action?

@lukeseawalker lukeseawalker force-pushed the master branch 4 times, most recently from e8bb8da to bdeb98d Compare November 5, 2020 09:53
Package will be updated to latest if version is not provided.
@lukeseawalker lukeseawalker changed the title Add upgrade action Add upgrade action to the pyenv_pip resource Nov 5, 2020
@ramereth ramereth merged commit 1fa851d into sous-chefs:master Nov 5, 2020
tilne pushed a commit to tilne/aws-parallelcluster-cookbook that referenced this pull request Feb 10, 2021
Don't skip installation if upgrade flag is provided but version it's not

PR reported in sous-chefs/pyenv#78

Signed-off-by: Luca Carrogu <[email protected]>
tilne pushed a commit to aws/aws-parallelcluster-cookbook that referenced this pull request Feb 11, 2021
Don't skip installation if upgrade flag is provided but version it's not

PR reported in sous-chefs/pyenv#78

Signed-off-by: Luca Carrogu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants