-
Notifications
You must be signed in to change notification settings - Fork 174
Move to functional components (Part IV) #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to functional components (Part IV) #2353
Conversation
Pull Request Test Coverage Report for Build 4380352133Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
The only things I'm concerned about are the following: - class SideContentToneMatrix extends React.Component<{}, {}> {
- private $container: HTMLElement | null = null;
+ const SideContentToneMatrix: React.FC = () => {
+ const containerRef = useRef<HTMLDivElement | null>(null);- class SideContentCanvasOutput extends React.Component<SideContentCanvasOutputProps, {}> {
- private $parent: HTMLElement | null = null;
+ const SideContentCanvasOutput: React.FC<SideContentCanvasOutputProps> = ({ canvas }) => {
+ const parentRef = useRef<HTMLDivElement>(null);Not sure if I did them correctly. @shenyih0ng could you help check this? Thanks a lot! |
martin-henz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Use FC for EditingOverviewCard * Use FC for MissionCreator * Use FC for EditingWorkspaceSideContentDeploymentTab * Reformat code and comments * Use FC for SourceRecorderShareCell * Use FC for SourceRecorderSelectCell * Use FC for SideContentToneMatrix * Use FC for SideContentCanvasOutput * Fix incorrect memoization * Standardise Drawable export/imports * Use FC for BackwardArrowDrawable * Improve comment formatting * Add back memoization * Use FC for ArrowDrawable --------- Co-authored-by: Martin Henz <[email protected]>
Description
Type of change
How to test
Checklist