Skip to content

Fix PartitionBodyLiteralsTransformer with subsumptive clause#2562

Merged
quentin merged 1 commit intosouffle-lang:masterfrom
quentin:issue-2551
Nov 6, 2025
Merged

Fix PartitionBodyLiteralsTransformer with subsumptive clause#2562
quentin merged 1 commit intosouffle-lang:masterfrom
quentin:issue-2551

Conversation

@quentin
Copy link
Member

@quentin quentin commented Nov 4, 2025

The PartitionBodyLiteralsTransformer did not handle subsumptive clauses and treated them as normal clause.

It's a design flaw of SubsumptiveClause being a subclass of Clause. Similar issue could happen for any transformation that rewrites a Clause.

fix #2551

The `PartitionBodyLiteralsTransformer` did not handle subsumptive
clauses and treated them as normal clause.

It's a design flaw of `SubsumptiveClause` being a subclass
of `Clause`. Similar issue could happen for any transformation that
rewrites a `Clause`.

fix souffle-lang#2551
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.15%. Comparing base (b37994d) to head (0447ecd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ast/transform/PartitionBodyLiterals.cpp 89.47% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
- Coverage   81.20%   81.15%   -0.05%     
==========================================
  Files         492      492              
  Lines       33370    30953    -2417     
==========================================
- Hits        27099    25121    -1978     
+ Misses       6271     5832     -439     
Files with missing lines Coverage Δ
src/ast/transform/SubsumptionQualifier.cpp 100.00% <100.00%> (ø)
src/ast/transform/PartitionBodyLiterals.cpp 97.95% <89.47%> (-2.05%) ⬇️

... and 339 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quentin quentin requested a review from julienhenry November 4, 2025 19:08
Copy link
Member

@julienhenry julienhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I am suprised we did not notice this problem earlier.

@quentin quentin marked this pull request as ready for review November 6, 2025 13:45
@quentin quentin merged commit 8abf896 into souffle-lang:master Nov 6, 2025
36 checks passed
@quentin quentin deleted the issue-2551 branch November 6, 2025 13:45
Codechicken pushed a commit to Codechicken/souffle that referenced this pull request Nov 27, 2025
…-lang#2562)

The `PartitionBodyLiteralsTransformer` did not handle subsumptive
clauses and treated them as normal clause.

It's a design flaw of `SubsumptiveClause` being a subclass
of `Clause`. Similar issue could happen for any transformation that
rewrites a `Clause`.

fix souffle-lang#2551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subsumption isn't always compiled

2 participants