Fix PartitionBodyLiteralsTransformer with subsumptive clause#2562
Merged
quentin merged 1 commit intosouffle-lang:masterfrom Nov 6, 2025
Merged
Fix PartitionBodyLiteralsTransformer with subsumptive clause#2562quentin merged 1 commit intosouffle-lang:masterfrom
quentin merged 1 commit intosouffle-lang:masterfrom
Conversation
The `PartitionBodyLiteralsTransformer` did not handle subsumptive clauses and treated them as normal clause. It's a design flaw of `SubsumptiveClause` being a subclass of `Clause`. Similar issue could happen for any transformation that rewrites a `Clause`. fix souffle-lang#2551
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
- Coverage 81.20% 81.15% -0.05%
==========================================
Files 492 492
Lines 33370 30953 -2417
==========================================
- Hits 27099 25121 -1978
+ Misses 6271 5832 -439
🚀 New features to boost your workflow:
|
julienhenry
approved these changes
Nov 5, 2025
Member
julienhenry
left a comment
There was a problem hiding this comment.
Thank you for the fix! I am suprised we did not notice this problem earlier.
Codechicken
pushed a commit
to Codechicken/souffle
that referenced
this pull request
Nov 27, 2025
…-lang#2562) The `PartitionBodyLiteralsTransformer` did not handle subsumptive clauses and treated them as normal clause. It's a design flaw of `SubsumptiveClause` being a subclass of `Clause`. Similar issue could happen for any transformation that rewrites a `Clause`. fix souffle-lang#2551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PartitionBodyLiteralsTransformerdid not handle subsumptive clauses and treated them as normal clause.It's a design flaw of
SubsumptiveClausebeing a subclass ofClause. Similar issue could happen for any transformation that rewrites aClause.fix #2551