Skip to content

Comments

[Feat] mode에 따라 primary 색상 다르게 적용#522

Merged
namdaeun merged 4 commits intodevelopfrom
feat/#521_primary-color
Aug 21, 2025
Merged

[Feat] mode에 따라 primary 색상 다르게 적용#522
namdaeun merged 4 commits intodevelopfrom
feat/#521_primary-color

Conversation

@namdaeun
Copy link
Member

@namdaeun namdaeun commented Aug 21, 2025

Related Issue : Closes #521


🧑‍🎤 Summary

Vite는 기본적으로 .env 파일을 로드하지 않는다고 해요.

스타일도 env.mode를 통해 분기 처리 해야하기 때문에 vite.config.ts에서 mode를 전달하여 빌드 타임에 컴파일 되는 vanilla extract에서 makers모드를 파악할 수 있게 변경했습니다.

  define: {
    __IS_MAKERS__: JSON.stringify(mode === 'makers'),
  },

또한 가독성을 위해 환경변수명을 __IS_MAKERS__로 변경해주었어요.

🧑‍🎤 Screenshot

스크린샷 2025-08-21 오후 5 00 39 스크린샷 2025-08-21 오후 5 00 49

🧑‍🎤 Comment

@namdaeun namdaeun requested a review from rtttr1 August 21, 2025 08:01
@namdaeun namdaeun self-assigned this Aug 21, 2025
@height
Copy link

height bot commented Aug 21, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 21, 2025
@cloudflare-workers-and-pages
Copy link

Deploying sopt-recruiting-frontend-sopt with  Cloudflare Pages  Cloudflare Pages

Latest commit: f686d3a
Status: ✅  Deploy successful!
Preview URL: https://efb0874c.sopt-recruiting-frontend-test.pages.dev
Branch Preview URL: https://feat--521-primary-color.sopt-recruiting-frontend-test.pages.dev

View logs

Copy link
Contributor

@rtttr1 rtttr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!! 빠른 작업 너무 좋아요~~!

@namdaeun namdaeun merged commit 4b4f809 into develop Aug 21, 2025
1 check passed
@namdaeun namdaeun deleted the feat/#521_primary-color branch August 21, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 메이커스 환경에서 primary color 분기 처리

2 participants