-
Notifications
You must be signed in to change notification settings - Fork 4
feat: 멤버 리스트 메이커스 기수 표기 #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 멤버 리스트 메이커스 기수 표기 #2190
Changes from all commits
9fa944d
fd7033b
ba8eaff
152edb6
e0b37f0
9295077
cd27c1b
833b1c0
1240ec3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| const APPLE_APP_SITE_ASSOCIATION = `{ | ||
| "applinks": { | ||
| "apps": [], | ||
| "details": [ | ||
| { | ||
| "appID": "95YWTT5L8K.com.sopt-stamp-iOS.release", | ||
| "paths": ["*"] | ||
| } | ||
| ] | ||
| } | ||
| }`; | ||
|
|
||
| export const onRequest: PagesFunction = () => { | ||
| return new Response(APPLE_APP_SITE_ASSOCIATION, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| }); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| const ASSETLINKS_JSON = `[ | ||
| { | ||
| "relation": ["delegate_permission/common.handle_all_urls"], | ||
| "target": { | ||
| "namespace": "android_app", | ||
| "package_name": "org.sopt.official", | ||
| "sha256_cert_fingerprints": [ | ||
| "29:23:1F:E3:7A:FD:76:9C:58:CA:F3:E2:D9:7C:A1:69:CF:04:A8:6E:5B:8A:C6:56:6A:6F:E8:FD:D8:FF:47:43" | ||
| ] | ||
| } | ||
| } | ||
| ]`; | ||
|
|
||
| export const onRequest: PagesFunction = () => { | ||
| return new Response(ASSETLINKS_JSON, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| }); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,13 @@ | ||
| {\rtf1\ansi\ansicpg1252\cocoartf2822 | ||
| \cocoatextscaling0\cocoaplatform0{\fonttbl\f0\froman\fcharset0 Times-Roman;} | ||
| {\colortbl;\red255\green255\blue255;\red0\green0\blue0;} | ||
| {\*\expandedcolortbl;;\cssrgb\c0\c0\c0;} | ||
| \paperw11900\paperh16840\margl1440\margr1440\vieww11520\viewh8400\viewkind0 | ||
| \deftab720 | ||
| \pard\pardeftab720\partightenfactor0 | ||
|
|
||
| \f0\fs24 \cf0 \expnd0\expndtw0\kerning0 | ||
| \{\ | ||
| \'93applinks\'94: \{\ | ||
| \'93apps\'94: [],\ | ||
| \'93details\'94: [\ | ||
| \{\ | ||
| \'93appID\'94: \'9395YWTT5L8K.com.sopt-stamp-iOS.release\'94,\ | ||
| \'93paths\'94: [\'93*\'94]\ | ||
| \}\ | ||
| ]\ | ||
| \}\ | ||
| \}} | ||
| { | ||
| "applinks": { | ||
| "apps": [], | ||
| "details": [ | ||
| { | ||
| "appID": "95YWTT5L8K.com.sopt-stamp-iOS.release", | ||
| "paths": [ | ||
| "*" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # Check if both files exist in the codebase
fd "apple-app-site-association" -t fRepository: sopt-makers/sopt-playground-frontend Length of output: 62 🏁 Script executed: # List files in the functions and public directories to understand structure
git ls-files | grep -E "(functions|public)" | grep -E "\.well-known|apple" | head -20Repository: sopt-makers/sopt-playground-frontend Length of output: 253 🌐 Web query:
💡 Result: On Cloudflare Pages (Functions mode), routing generally works like this:
The key control:
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -95,6 +95,10 @@ export const handleTokenError = async (error: AxiosError<unknown>) => { | |||||||||||||||||
| // 개인정보 처리방침 페이지는 로그인 필요 없음, 구글 정책상 오픈 | ||||||||||||||||||
| return Promise.reject(error); | ||||||||||||||||||
| } | ||||||||||||||||||
| // 에스크 문자를 통한 딥링크 접근을 위해 허용 | ||||||||||||||||||
| if (window.location.pathname === '/.well-known/apple-app-site-association' || '/.well-known/assetlinks.json') { | ||||||||||||||||||
| return Promise.reject(error); | ||||||||||||||||||
| } | ||||||||||||||||||
|
Comment on lines
+98
to
+101
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 크리티컬 버그: 조건문이 항상
🐛 수정 제안- if (window.location.pathname === '/.well-known/apple-app-site-association' || '/.well-known/assetlinks.json') {
+ if (window.location.pathname === '/.well-known/apple-app-site-association' || window.location.pathname === '/.well-known/assetlinks.json') {
return Promise.reject(error);
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| /** 토큰이 없으면 refresh 시도하지 않고 바로 intro로 이동 */ | ||||||||||||||||||
| const currentToken = tokenStorage.get(); | ||||||||||||||||||
| if (currentToken === null && window.location.pathname !== '/intro') { | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
rg -n "CREW_API_URL" --type=ts -C3Repository: sopt-makers/sopt-playground-frontend
Length of output: 1589
🏁 Script executed:
rg -n "crew-api" --type=ts -C3Repository: sopt-makers/sopt-playground-frontend
Length of output: 62
🏁 Script executed:
Repository: sopt-makers/sopt-playground-frontend
Length of output: 250
🏁 Script executed:
Repository: sopt-makers/sopt-playground-frontend
Length of output: 350
🏁 Script executed:
Repository: sopt-makers/sopt-playground-frontend
Length of output: 4614
🏁 Script executed:
# Check other API URLs for consistency cat .env.developmentRepository: sopt-makers/sopt-playground-frontend
Length of output: 746
🏁 Script executed:
Repository: sopt-makers/sopt-playground-frontend
Length of output: 2017
🏁 Script executed:
Repository: sopt-makers/sopt-playground-frontend
Length of output: 62
Trailing slash를 제거하여 다른 API URL과 일관성을 맞추세요.
NEXT_PUBLIC_CREW_API_URL의 trailing slash는 API 엔드포인트(/internal/meeting/stats/likes등)와 결합될 때 이중 슬래시(//)를 유발합니다. 다른 API URL들(NEXT_PUBLIC_API_URL,NEXT_PUBLIC_AUTH_API_URL,NEXT_PUBLIC_OPERATION_API_URL)은 모두 trailing slash가 없으므로 제거가 필요합니다.🔧 수정 제안
파일 끝에 빈 줄을 추가하세요(EOF newline 규칙).
🧰 Tools
🪛 dotenv-linter (4.0.0)
[warning] 14-14: [EndingBlankLine] No blank line at the end of the file
(EndingBlankLine)
[warning] 14-14: [UnorderedKey] The NEXT_PUBLIC_CREW_API_URL key should go before the NEXT_PUBLIC_DEBUG key
(UnorderedKey)
🤖 Prompt for AI Agents