Conversation
Summary by CodeRabbit릴리스 노트
Walkthrough
Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 프리뷰 배포 확인하기 🚀 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.env.development:
- Line 14: The .env entry for NEXT_PUBLIC_CREW_API_URL is missing a trailing
newline at EOF which breaks dotenv-linter; open the .env.development file and
add a single blank line/line break after the existing line containing
NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org so the file ends with a
newline character.
🧹 Nitpick comments (2)
src/components/feed/common/utils.ts (1)
59-61: 중첩 삼항 연산자로 인한 가독성 저하
is특수임원,isMakers두 가지 분기가 한 줄에 중첩되어 있어 가독성이 떨어집니다.♻️ 리팩터링 제안
- const defaultInfo = `${post.member.activity.generation}기 ${ - is특수임원 ? post.member.activity.part : isMakers ? '메이커스' :`${post.member.activity.part}파트` - }`; + const roleLabel = is특수임원 + ? post.member.activity.part + : isMakers + ? '메이커스' + : `${post.member.activity.part}파트`; + + const defaultInfo = `${post.member.activity.generation}기 ${roleLabel}`;src/components/feed/home/SopticleArea/SopticleCard.tsx (1)
27-34:categoryId: 21대신 이미 import된 상수를 사용하세요.Line 8에서
SOPTICLE_CATEGORY_ID를 이미 import하고 있으므로, 매직 넘버21대신 해당 상수를 사용하는 것이 좋습니다.♻️ 수정 제안
{getMemberInfo({ - categoryId: 21, + categoryId: SOPTICLE_CATEGORY_ID, categoryName: '솝티클', member: { activity: member?.activity ?? { generation: 0, part: '', team: null }, careers: member?.careers ?? null, }, })}
.env.development
Outdated
| NEXT_PUBLIC_CREW_API_URL=https://crew.api.dev.sopt.org No newline at end of file | ||
| NEXT_PUBLIC_OPERATION_API_URL=https://operation-api.dev.sopt.org | ||
| NEXT_PUBLIC_AUTH_API_URL=https://auth-api.dev.sopt.org | ||
| NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org No newline at end of file |
There was a problem hiding this comment.
파일 끝에 빈 줄이 없습니다.
정적 분석 도구(dotenv-linter)에서 파일 끝 빈 줄 누락이 감지되었습니다.
🔧 수정 제안
-NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org
+NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org
+📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org | |
| NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org | |
🧰 Tools
🪛 dotenv-linter (4.0.0)
[warning] 14-14: [EndingBlankLine] No blank line at the end of the file
(EndingBlankLine)
[warning] 14-14: [UnorderedKey] The NEXT_PUBLIC_CREW_API_URL key should go before the NEXT_PUBLIC_DEBUG key
(UnorderedKey)
🤖 Prompt for AI Agents
In @.env.development at line 14, The .env entry for NEXT_PUBLIC_CREW_API_URL is
missing a trailing newline at EOF which breaks dotenv-linter; open the
.env.development file and add a single blank line/line break after the existing
line containing NEXT_PUBLIC_CREW_API_URL=https://crew-api-dev.sopt.org so the
file ends with a newline character.
There was a problem hiding this comment.
공홈. https://org-api-dev.sopt.org/
어드민. https://operation-api-dev.sopt.org/
인증서버. https://auth-dev-api.sopt.org/
플레이그라운드. https://playground-dev.sopt.org/
앱. https://app-dev.sopt.org/
크루. https://crew-dev.sopt.org/
https://sopt-makers.slack.com/archives/C09QZ8DJ4N8/p1768726163137479
해당 스레드랑 달라서 확인 한 번 해주세요!
There was a problem hiding this comment.
@ljh0608 님이 지적해주신 내용 확인했습니다!
현재 PR의 URL들과 제공해주신 정식 엔드포인트 간에 차이가 있습니다:
불일치 항목:
-
NEXT_PUBLIC_OPERATION_API_URL
- PR:
https://operation-api.dev.sopt.org - 정식:
https://operation-api-dev.sopt.org
- PR:
-
NEXT_PUBLIC_AUTH_API_URL
- PR:
https://auth-api.dev.sopt.org - 정식:
https://auth-dev-api.sopt.org
- PR:
-
NEXT_PUBLIC_CREW_API_URL
- PR:
https://crew-api-dev.sopt.org - 정식:
https://crew-dev.sopt.org
- PR:
-
NEXT_PUBLIC_ADMIN_API_URL
- PR:
https://api-dev-api.sopt.org/v2 - (제공하신 목록에는 "공홈:
https://org-api-dev.sopt.org/"가 있는데, Admin API와 매칭되는지 확인 필요)
- PR:
서브도메인 형식이 달라서 (예: auth-api.dev vs auth-dev-api) API 호출이 실패할 수 있습니다. Slack 스레드에 명시된 정식 URL로 수정이 필요해 보입니다. 확인 부탁드립니다!
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.env.development (1)
1-14:⚠️ Potential issue | 🟡 Minor키 정렬 순서가 linter 규칙과 다릅니다.
dotenv-linter가 여러 키의 정렬 순서 위반을 보고합니다. 규칙에 맞게 키 순서를 재배치해 주세요.
2 participants
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
getMemberInfo에 isMakers 추가했어요
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?