Opt out of default features (serde) for ipnetwork#4
Merged
sophacles merged 1 commit intosophacles:mainfrom May 10, 2025
Merged
Conversation
Brings down the transitive dependency tree significantly. This crate does not use the serialization functionality of ipnetwork anyway! Default features was a mistake in Cargo :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for a really nice crate! Being able to create const/static IP types that are properly checked at compile time has been something I have wanted for a long time. This crate solves part of that problem very elegantly ✨
When depending on
const-addrsand enabling theipnetfeature, I also getserdeas a transitive dependency. None of the code in my dependency tree usesserdefor anything. This is just the unfortunate situation we are in with default features in Cargo. I regard them as an antipattern more than anything else.This PR opts out of any default features in
ipnetwork. Currently that's simply theserdefunctionality being removed.I have submitted a PR towards
ipnetworkto removeserdeas a default feature also. So this might be solved in a future release. We can't know yet: achanda/ipnetwork#200