Open
Conversation
sophacles
force-pushed
the
issue_9_additional_ipnet_types
branch
3 times, most recently
from
9481a46 to
32c9e74
Compare
sophacles
changed the title
This involves a couple of things:
* support for IpRange types and IpSubnets types. These are not simple
fromstr implementations so the make_macro! approach didn't work.
Instead a heck of a lot of proc-macro code was needed to parse and
validate the args lists.
* A separate set of tests for nightly vs stable builds in some cases.
Reasons for this:
1) compiler output is slightly different between nightly and stable.
2) there is warning support in nightly and this emits warnings when
the generated iterators might behave different than expected.
Fixes: #21
sophacles
force-pushed
the
issue_9_additional_ipnet_types
branch
from
32c9e74 to
587a097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Add support for additional ipnet types
This involves a couple of things:
support for IpRange types and IpSubnets types. These are not simple
fromstr implementations so the make_macro! approach didn't work.
Instead a heck of a lot of proc-macro code was needed to parse and
validate the args lists.
A separate set of tests for nightly vs stable builds in some cases.
Reasons for this:
1) compiler output is slightly different between nightly and stable.
2) there is warning support in nightly and this emits warnings when
the generated iterators might behave different than expected.
Fixes: #21
Checklist: