Merged
Conversation
Previously the list command only listed out a bunch of AppIDs, now in addition to listing the AppIDs it can also list the game name, game path, and all three. The help page still needs updated to reflect these changes. There is also an issue with getting the name from the App Manifest, which was implemented outside of this PR. xargs, which is used to strip trailing whitespace from the game names fetched from the App Manifest, doesn't like when game names have 'unmatched' single quotes in them, e.g. "Shantae and the Pirate's Curse"
Owner
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the list command only listed out a bunch of AppIDs, now in addition to listing the AppIDs it can also list the game name, game path, and all three.
This PR also does some minor updates to the
getGameDirfunction. There is an internal change to allow only listing the path without listing the game name and AppID, an option to expose this to the user could be implemented fairly easily and will probably be done outside of this PR. The other update is a bugfix which caused soundtracks to be returned as not found, asgetGameDironly checkssteamapps/commonin each library folder, whereas soundtracks are stored atsteamapps/music.There is an outstanding issue with getting the name from the App Manifest, which was implemented outside of this PR. xargs, which is used to strip trailing whitespace from the game names fetched from the App Manifest, doesn't like when game names have 'unmatched' single quotes in them, e.g. "Shantae and the Pirate's Curse". This will need to be addressed, but could be addressed in a separate PR as some other places which use the function to get a value from the App Manifest will need to be tested.
The help page needs updated to reflect the changes to the
listfunction.