Conversation
…ing from Compatibility Tool If a native game is launched with a Steam Linux Runtime Compatibility Tool selected, either by the user or Valve Testing, the Steam Linux Runtime will come in the game launch command. However a user may want to ignore this for any reason, so this adds a checkbox to allow users to ignore the incoming Steam Linux Runtime and let SteamTinkerLaunch find it.
Owner
Author
|
CI is running twice, god dammit... |
Owner
Author
|
Okay, CI seems fixed now. It should only run on push for branches, and will run for pull request events if the branch is from a fork. |
Owner
Author
|
Tested the following games, eveything works as expected:
This PR seems to be ready to merge pending a version bump. EDIT: Oops, didn't push the change I had locally to make a change in logic to when we check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1088.
Soft prerequisite for #1087.
If a native game is launched with a Steam Linux Runtime Compatibility Tool selected, either by the user or Valve Testing, the Steam Linux Runtime will come in the game launch command. However a user may want to ignore this for any reason, so this adds a checkbox to allow users to ignore the incoming Steam Linux Runtime and let SteamTinkerLaunch find it.
This has only been minimally tested, and needs regression testing. Also, langfiles need to be updated. I noticed in testing
DESC_USESLR, a string unrelated to this PR, has a typo, so I fixed it in theenglish.txt. This will also need to be fixed in other langfiles where appropriate alongside adding the new strings for the checkbox in this PR to the other langfiles.This PR is a soft prerequisite for #1087 because it makes that feature more useful. By allowing to disable the incoming SLR in this PR, it means choosing a different SLR is much easier. Once #1087 is implemented it means a user could use this PR to disable a Valve Testing-selected SLR 1.0, and then use #1087 to select SLR 3.0 to let STL find that SLR for the game.
Following this PR and any work for related issue #1087, we need to update the Steam Linux Runtime wiki page to have more information about what it is, how SteamTinkerLaunch uses it (will attempt to find the required Steam Linux Runtime stipulated by a Proton version's
toolmanifest.vdf, otherwise will default to SLR 1.0 for native games, and if an SLR is incoming for a native game from a selected SLR compatibility tool then STL will always use this unless this PR's checkbox is enabled).