Commandline: Flatten getGameExe checks#1031
Merged
Conversation
sonic2kk
force-pushed
the
flatten-getgameexe
branch
from
5bf64bc to
6b8f737
Compare
This was referenced Jan 27, 2024
sonic2kk
force-pushed
the
flatten-getgameexe
branch
from
6b8f737 to
c4e6991
Compare
Owner
Author
|
Bumped version with a rebase, works in testing. ShellCheck is green. This should be ready to merge. |
This was referenced Jan 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More recent codebase additions have been using the (in my opinion, more readable) return-early paradigm. This flattens the checks instead of containing everything in a big
elseblock. This was recently done forgetTitleFromIDin #1011.In testing, this seems to work just as well, but I will do more testing before merging.