Build - use Qt5::<lib> targets for Qt 5.12 compatibility #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for Ubuntu 20.04 support. This should probably be reverted when we drop support for Ubuntu 20.04 (the current LTS 22.04 does not need this).
Collaborator
|
Cool! When do you think we should drop support for Ubuntu 20.04? |
Contributor
Author
|
I'd probably give people a year to a year and a half from the 22.04 release date to upgrade from 20.04 (so between April and October of next year I suppose), unless anyone has other input |
Collaborator
|
This is fab, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Ubuntu 20.04 support
This should probably be reverted when we drop support for Ubuntu 20.04 (the current LTS 22.04 does not need this)
Fixes #3124