Filter out non-printable characters read from syseeprom#17
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jun 25, 2020
Merged
Conversation
Signed-off-by: Rajendra Dendukuri <[email protected]>
Collaborator
Author
|
@xumia Can you please help me with the check failure that I am seeing. This is the first PR that I am pushing after Azure/sonic-build-tools#84 is merged. |
|
retest buster please |
|
retest this please |
1 similar comment
Contributor
|
retest this please |
rajendra-dendukuri
added a commit
that referenced
this pull request
Jul 6, 2020
Signed-off-by: Rajendra Dendukuri <[email protected]>
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 7, 2020
Cherry pick sonic-net/sonic-ztp#17 to 201911 branch to fix sonic-net/sonic-ztp#15
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 23, 2020
* [MultiDB] Add multidb support to sonic-ztp * Hide stray output message while removing ZTP config * Filter out non-printable characters read from syseeprom (#17) * Update all references to new 'sonic-installer' file name * Update paths to reflect new utilities install location, /usr/local/bin/ * [MultiDB] Add multidb support to sonic-ztp * Hide stray output message while removing ZTP config * Fix additional review comments * Remove duplicate configdb connector creation * Remove references to host address while creating a DB connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added defensive code to check for printable characters in the output of decode-syseeprom command.
Fixes #15
Signed-off-by: Rajendra Dendukuri [email protected]