Fix GCC 14 build error: add hostapd_deinit_driver declaration#114
Merged
yxieca merged 1 commit intosonic-net:masterfrom Apr 3, 2026
Merged
Fix GCC 14 build error: add hostapd_deinit_driver declaration#114yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
…apd.h GCC 14 (Debian trixie) treats implicit function declarations as errors. hostapd_deinit_driver() is called in hostapd/main.c but was not declared in any header. Add the prototype to src/ap/hostapd.h under CONFIG_SONIC_HOSTAPD guard. This fixes the build failure blocking the docker-macsec trixie upgrade (sonic-net/SONiC#2169). Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix build failure with GCC 14 (Debian trixie) where implicit function declarations are treated as errors.
Fixes #113
Root Cause
hostapd_deinit_driver()is defined insrc/ap/hostapd.c(non-static underCONFIG_SONIC_HOSTAPD) but has no prototype in any header. GCC 14 errors on this:Changes
src/ap/hostapd.h: Add function prototype under#ifdef CONFIG_SONIC_HOSTAPDTesting
Impact
Blocks the docker-macsec trixie upgrade tracked in sonic-net/SONiC#2169