[sonic-installer] Update group name for 'verify-next-image' subcommand#995
Merged
jleveque merged 1 commit intosonic-net:masterfrom Jul 19, 2020
jleveque:installer_verify_fix
Merged
[sonic-installer] Update group name for 'verify-next-image' subcommand#995jleveque merged 1 commit intosonic-net:masterfrom jleveque:installer_verify_fix
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:installer_verify_fix
Conversation
qiluo-msft
approved these changes
Jul 17, 2020
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Suggest add test cases to prevent it in future.
Contributor
Author
|
@qiluo-msft: I opened a new issue to track this: #996 |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
8 similar comments
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
Retest this please |
Contributor
Author
|
The check failures are unrelated to this PR. Since the PR is a bugfix, I am going to merge this in spite of the check failures. |
jleveque
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 20, 2020
* src/sonic-utilities a23479e...82dfe50 (3): > [sonic-installer] Update group name for 'verify-next-image' subcommand (#/995) > [acl_loader] Fix bugs in acl_loader (#991) > [show] Add support for QSFP-DD cables on 'show' command (#989) This submodule update resolves sonic-net/sonic-utilities#997 by including PR sonic-net/sonic-utilities#995
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root group name was changed from
clitosonic_installerin #983. However,verify-next-imagesubcommand was being added in an already-open PR #979 at the time. It did not get updated before merge. This aligns it with the new group name.