[acl-loader] Fix bugs in acl-loader#991
Merged
daall merged 1 commit intosonic-net:masterfrom Jul 16, 2020
Merged
Conversation
- Support protocol number == 0 - Emit warning if --table_name not found in Config DB Signed-off-by: Danny Allen <[email protected]>
Contributor
Author
|
retest this please |
jleveque
approved these changes
Jul 16, 2020
Contributor
Author
|
retest this please |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Update submodule sonic-sairedis that contains the following commit: Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor (sonic-net#908) (sonic-net#991)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
- What I did/How I did it
I fixed a bug in acl-loader where rules with protocol=0 would have the protocol field ignored due to python's implicit boolean conversion. I fixed this by explicitly adding the
== 0check to the ip protocol field.I also fixed/added a warning when the provided
--table_namecan't be found in Config DB. Previously this case would fail silently, now the user will receive a warning to point them in the right direction.- How to verify it
Run
acl-loaderwith a non-existent--table_name:Run
acl-loaderwith a rule that includes"protocol": 0:- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)