[show] Add 'show' CLI for system-health feature by shlomibitton · Pull Request #971 · sonic-net/sonic-utilities

shlomibitton · 2020-06-30T11:37:21Z

- What I did
Add 'show' CLI for system-health feature.
Add Unit test for the new CLI.

Commands:
- summary Show system-health summary information
- detail Show system-health detail information
- monitor-list Show system-health monitored services and devices name list

- How I did it
Added support to 'show' script.
Added new unit test.

- How to verify it
Run commands:
- show system-health summary
- show system-health summary
- show system-health summary

- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)

Signed-off-by: Shlomi Bitton <[email protected]>

lgtm-com · 2020-06-30T11:43:21Z

This pull request introduces 4 alerts when merging 8a634ab into aae89b7 - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
1 for Unused import

… 'show' script, Fix comments Signed-off-by: Shlomi Bitton <[email protected]>

lgtm-com · 2020-07-06T19:03:32Z

This pull request introduces 4 alerts when merging 61d90ac into 60e5410 - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
1 for Unused import

keboliu · 2020-07-07T14:45:40Z

retest this please

…o shlomi_system_health_cli

shlomibitton · 2020-07-09T17:20:19Z

retest this please

lgtm-com · 2020-07-13T13:27:05Z

This pull request introduces 4 alerts when merging f63c8b0924dd790662051ae8d6ce431332720e9b into b4b5fd3 - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
1 for Unused import

lgtm-com · 2020-07-13T14:21:47Z

This pull request introduces 4 alerts when merging 04d0672 into b4b5fd3 - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
1 for Unused import

show/main.py

sonic-utilities-tests/system_health_test.py

lgtm-com · 2020-07-14T12:28:30Z

This pull request introduces 4 alerts when merging c04dfed into a23479e - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
1 for Unused import

liat-grozovik

@shlomibitton this PR is missing command line reference update. Please update it as well

jleveque

Please fix LGTM alerts.

Add a CLI reference for system-health feature.

lgtm-com · 2020-07-15T13:54:12Z

This pull request introduces 4 alerts when merging d33454c into a23479e - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
1 for Unused import

lgtm-com · 2020-07-15T15:00:22Z

This pull request introduces 1 alert when merging 28f9625 into a23479e - view on LGTM.com

new alerts:

1 for Unused import

shlomibitton · 2020-07-15T15:05:06Z

@liat-grozovik the CLI reference added, please review.
@jleveque 3 LGTM alerts fixed, last alert is because of an import needed for unit testing.

doc/Command-Reference.md

show/main.py

Change 'Ignore' to 'Ignored'

sonic-net/sonic-buildimage@8ea2ab5 Signed-off-by: Shlomi Bitton <[email protected]>

show/main.py

show/system_health.py

tests/system_health_test.py

liat-grozovik · 2020-10-12T08:14:57Z

@jleveque can you please confirm your comments are resolved so we can merge?

Add 'show' CLI for system-health feature

d58195e

Signed-off-by: Shlomi Bitton <[email protected]>

shlomibitton changed the title ~~Add 'show' CLI for system-health feature~~ [Mellanox] Add 'show' CLI for system-health feature Jun 30, 2020

keboliu requested a review from jleveque June 30, 2020 14:38

shlomibitton changed the title ~~[Mellanox] Add 'show' CLI for system-health feature~~ [system health] Add 'show' CLI for system-health feature Jun 30, 2020

Add unit test for 'system-health' feature, add support for testing in…

61d90ac

… 'show' script, Fix comments Signed-off-by: Shlomi Bitton <[email protected]>

Merge branch 'master' of https://github.com/Azure/sonic-utilities int…

0fc2d48

…o shlomi_system_health_cli

Fix additional comments

04d0672

jleveque changed the title ~~[system health] Add 'show' CLI for system-health feature~~ [show] Add 'show' CLI for system-health feature Jul 13, 2020

jleveque added Enhancement show labels Jul 13, 2020

jleveque suggested changes Jul 13, 2020

View reviewed changes

show/main.py Outdated Show resolved Hide resolved

sonic-utilities-tests/system_health_test.py Outdated Show resolved Hide resolved

Fix comments

c04dfed

liat-grozovik requested changes Jul 14, 2020

View reviewed changes

jleveque suggested changes Jul 14, 2020

View reviewed changes

Update Command-Reference.md

d33454c

Add a CLI reference for system-health feature.

Fix LGTM alerts

28f9625

jleveque reviewed Jul 15, 2020

View reviewed changes

doc/Command-Reference.md Outdated Show resolved Hide resolved

jleveque suggested changes Jul 15, 2020

View reviewed changes

show/main.py Outdated Show resolved Hide resolved

shlomibitton mentioned this pull request Jul 16, 2020

[system-health] Add support for monitoring system health sonic-net/sonic-buildimage#4835

Merged

Fix comment

393c3de

Change 'Ignore' to 'Ignored'

Align changes in the feature to the CLI on commit

eb6409f

sonic-net/sonic-buildimage@8ea2ab5 Signed-off-by: Shlomi Bitton <[email protected]>

Junchao-Mellanox reviewed Sep 9, 2020

View reviewed changes

show/main.py Outdated Show resolved Hide resolved

Update main.py

e0794ae

Junchao-Mellanox previously approved these changes Sep 9, 2020

View reviewed changes

jleveque suggested changes Sep 9, 2020

View reviewed changes

show/main.py Outdated Show resolved Hide resolved

Move new group CLI into a separate file

872030f

shlomibitton dismissed Junchao-Mellanox’s stale review via 872030f September 10, 2020 09:22

Merge branch 'master' into shlomi_system_health_cli

bd57109

shlomibitton requested a review from jleveque September 10, 2020 09:25

Junchao-Mellanox previously approved these changes Sep 10, 2020

View reviewed changes

jleveque suggested changes Sep 10, 2020

View reviewed changes

show/system_health.py Show resolved Hide resolved

tests/system_health_test.py Show resolved Hide resolved

Organize imports per PEP8 standards

ee85d43

shlomibitton dismissed Junchao-Mellanox’s stale review via ee85d43 September 13, 2020 07:58

shlomibitton requested a review from jleveque September 14, 2020 07:32

jleveque suggested changes Sep 14, 2020

View reviewed changes

tests/system_health_test.py Show resolved Hide resolved

Organize imports per PEP8 standards

5be5fd6

shlomibitton requested a review from jleveque September 14, 2020 18:22

jleveque suggested changes Sep 14, 2020

View reviewed changes

tests/system_health_test.py Outdated Show resolved Hide resolved

tests/system_health_test.py Outdated Show resolved Hide resolved

Reformat docstring for readability

5b1c981

shlomibitton requested a review from jleveque September 16, 2020 11:11

jleveque requested a review from sujinmkang September 16, 2020 16:12

sujinmkang approved these changes Sep 25, 2020

View reviewed changes

liat-grozovik approved these changes Oct 12, 2020

View reviewed changes

jleveque approved these changes Oct 12, 2020

View reviewed changes

liat-grozovik merged commit a71c72b into sonic-net:master Oct 12, 2020

This was referenced Oct 13, 2020

[submodule] Update sonic-utilities submodule keboliu/sonic-buildimage#7

Closed

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#5608

Closed

shlomibitton deleted the shlomi_system_health_cli branch March 24, 2021 20:41

Conversation

shlomibitton commented Jun 30, 2020

Uh oh!

lgtm-com bot commented Jun 30, 2020

Uh oh!

lgtm-com bot commented Jul 6, 2020

Uh oh!

keboliu commented Jul 7, 2020

Uh oh!

shlomibitton commented Jul 9, 2020

Uh oh!

lgtm-com bot commented Jul 13, 2020

Uh oh!

lgtm-com bot commented Jul 13, 2020

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Jul 14, 2020

Uh oh!

liat-grozovik left a comment

Choose a reason for hiding this comment

Uh oh!

jleveque left a comment

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Jul 15, 2020

Uh oh!

lgtm-com bot commented Jul 15, 2020

Uh oh!

shlomibitton commented Jul 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liat-grozovik commented Oct 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants