Skip to content

[sfpshow][mock_state_db] Tweak key names of some transceiver info fields#958

Merged
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:tweak_keys
Jun 25, 2020
Merged

[sfpshow][mock_state_db] Tweak key names of some transceiver info fields#958
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:tweak_keys

Conversation

@jleveque
Copy link
Contributor

Change the following key names:

  • hardwarerev -> hardware_rev
  • serialnum -> serial
  • manufacturename -> manufacturer
  • modelname -> model
  • Connector -> connector

Depends on:

Copy link
Collaborator

@keboliu keboliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleveque jleveque requested a review from lguohan June 24, 2020 03:22
@jleveque
Copy link
Contributor Author

Retest this please

@daall
Copy link
Contributor

daall commented Jun 25, 2020

retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque jleveque merged commit fa19b4c into sonic-net:master Jun 25, 2020
@jleveque jleveque deleted the tweak_keys branch June 25, 2020 21:50
abdosi pushed a commit that referenced this pull request Jul 8, 2020
…lds (#958)

Change the following key names:

- hardwarerev -> hardware_rev
- serialnum -> serial
- manufacturename -> manufacturer
- modelname -> model
- Connector -> connector

Depends on:
- sonic-net/sonic-platform-common#97
- sonic-net/sonic-platform-daemons#62
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
…lds (sonic-net#958)

Change the following key names:

- hardwarerev -> hardware_rev
- serialnum -> serial
- manufacturename -> manufacturer
- modelname -> model
- Connector -> connector

Depends on:
- sonic-net/sonic-platform-common#97
- sonic-net/sonic-platform-daemons#62
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[sfpshow][mock_state_db] Tweak key names of some transceiver info fields
(sonic-net#958)
[config] Fix syntax error (sonic-net#966)
[config] Fix indentation level in _get_disabled_services_list() (sonic-net#965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants