Add watchdogutil to control the hw watchdog#945
Merged
sujinmkang merged 12 commits intosonic-net:masterfrom Jul 8, 2020
Merged
Add watchdogutil to control the hw watchdog#945sujinmkang merged 12 commits intosonic-net:masterfrom
sujinmkang merged 12 commits intosonic-net:masterfrom
Conversation
|
This pull request introduces 3 alerts when merging 5a40f00 into a21e01a - view on LGTM.com new alerts:
|
jleveque
suggested changes
Jun 15, 2020
jleveque
suggested changes
Jun 16, 2020
|
This pull request introduces 1 alert when merging c7316da into fd7781b - view on LGTM.com new alerts:
|
jleveque
suggested changes
Jun 19, 2020
Contributor
jleveque
left a comment
There was a problem hiding this comment.
Please add sample command output to the PR description.
Collaborator
Author
|
@jleveque PR description updated |
jleveque
suggested changes
Jun 28, 2020
jleveque
suggested changes
Jun 28, 2020
Contributor
|
retest this please |
jleveque
suggested changes
Jul 1, 2020
jleveque
reviewed
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
suggested changes
Jul 2, 2020
jleveque
approved these changes
Jul 2, 2020
Collaborator
Author
|
retest this please |
5 similar comments
Collaborator
Author
|
retest this please |
Collaborator
Author
|
retest this please |
Collaborator
Author
|
retest this please |
Collaborator
Author
|
retest this please |
Collaborator
Author
|
retest this please |
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
* Add watchdogutil to control the hw watchdog * fix LGTM * Fixed based on review comments * replace the is_armed() and get_remaining_time to status() subcommand * syntax error * Add more info to the output * re-format of output * remove spaces * change the version number of watchdogutil * Change the output parsing for the watchdog arm case * typo * fix more review comments
abdosi
pushed a commit
that referenced
this pull request
Aug 22, 2020
* Add watchdogutil to control the hw watchdog * fix LGTM * Fixed based on review comments * replace the is_armed() and get_remaining_time to status() subcommand * syntax error * Add more info to the output * re-format of output * remove spaces * change the version number of watchdogutil * Change the output parsing for the watchdog arm case * typo * fix more review comments
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Add watchdogutil to control the hw watchdog (sonic-net#945) [db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#1053) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add a command line utility to control the hw watchdog arm/disarm
- How I did it
Add watchdogutil
- How to verify it
Check the syslog
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)