Skip to content

Add watchdogutil to control the hw watchdog#945

Merged
sujinmkang merged 12 commits intosonic-net:masterfrom
sujinmkang:hwwatchdog
Jul 8, 2020
Merged

Add watchdogutil to control the hw watchdog#945
sujinmkang merged 12 commits intosonic-net:masterfrom
sujinmkang:hwwatchdog

Conversation

@sujinmkang
Copy link
Copy Markdown
Collaborator

@sujinmkang sujinmkang commented Jun 14, 2020

- What I did
Add a command line utility to control the hw watchdog arm/disarm
- How I did it
Add watchdogutil
- How to verify it
Check the syslog
- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

user@server:~$ sudo watchdogutil status
Status : Unarmed
user@server:~$ sudo watchdogutil arm
Watchdog armed for 180 seconds
user@server:~$ sudo watchdogutil disarm
Watchdog disarmed successfully

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 14, 2020

This pull request introduces 3 alerts when merging 5a40f00 into a21e01a - view on LGTM.com

new alerts:

  • 3 for Unused import

@sujinmkang sujinmkang requested a review from jleveque June 15, 2020 23:05
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 17, 2020

This pull request introduces 1 alert when merging c7316da into fd7781b - view on LGTM.com

new alerts:

  • 1 for Syntax error

Copy link
Copy Markdown
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add sample command output to the PR description.

@sujinmkang
Copy link
Copy Markdown
Collaborator Author

@jleveque PR description updated

@renukamanavalan
Copy link
Copy Markdown
Contributor

retest this please

@sujinmkang
Copy link
Copy Markdown
Collaborator Author

retest this please

5 similar comments
@sujinmkang
Copy link
Copy Markdown
Collaborator Author

retest this please

@sujinmkang
Copy link
Copy Markdown
Collaborator Author

retest this please

@sujinmkang
Copy link
Copy Markdown
Collaborator Author

retest this please

@sujinmkang
Copy link
Copy Markdown
Collaborator Author

retest this please

@sujinmkang
Copy link
Copy Markdown
Collaborator Author

retest this please

@sujinmkang sujinmkang merged commit 7c512f3 into sonic-net:master Jul 8, 2020
@sujinmkang sujinmkang deleted the hwwatchdog branch July 8, 2020 18:25
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
* Add watchdogutil to control the hw watchdog

* fix LGTM

* Fixed based on review comments

* replace the is_armed() and get_remaining_time to status() subcommand

* syntax error

* Add more info to the output

* re-format of output

* remove spaces

* change the version number of watchdogutil

* Change the output parsing for the watchdog arm case

* typo

* fix more review comments
abdosi pushed a commit that referenced this pull request Aug 22, 2020
* Add watchdogutil to control the hw watchdog

* fix LGTM

* Fixed based on review comments

* replace the is_armed() and get_remaining_time to status() subcommand

* syntax error

* Add more info to the output

* re-format of output

* remove spaces

* change the version number of watchdogutil

* Change the output parsing for the watchdog arm case

* typo

* fix more review comments
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Add watchdogutil to control the hw watchdog (sonic-net#945)
[db_migrator] Support migrating database regarding buffer
configuration for all Mellanox switches (sonic-net#1053)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants