Skip to content

[Vnet] Fix NameError for 'swsssdk' and align output#902

Merged
prsunny merged 2 commits intosonic-net:masterfrom
prsunny:vnet_cli
May 6, 2020
Merged

[Vnet] Fix NameError for 'swsssdk' and align output#902
prsunny merged 2 commits intosonic-net:masterfrom
prsunny:vnet_cli

Conversation

@prsunny
Copy link
Contributor

@prsunny prsunny commented May 4, 2020

- What I did

  1. Fix NameError:
admin@str-sn-01:~$ show vnet routes tunnel
    appl_db = swsssdk.SonicV2Connector()
NameError: global name 'swsssdk' is not defined
  1. Fix empty output for neighbors
admin@str-sn-01:~$ show vnet neighbors 
admin@str-sn-01:~$ 

- How I did it
Code Fix - SonicV2Connector is already imported from swsssdk in the file

- How to verify it
Rerun commands

- Previous command output (if the output of a command-line utility has changed)

admin@str-sn-01:~$ show vnet neighbors 
admin@str-sn-01:~$ 

- New command output (if the output of a command-line utility has changed)

admin@str-sn-01:~$ show vnet neighbors 
<vnet_name>    neighbor    mac_address    interfaces
-------------  ----------  -------------  ------------

admin@str-sn-01:~$

@prsunny
Copy link
Contributor Author

prsunny commented May 4, 2020

@dzhangalibaba, please review

jleveque
jleveque previously approved these changes May 4, 2020
@prsunny
Copy link
Contributor Author

prsunny commented May 4, 2020

retest this please

1 similar comment
@daall
Copy link
Contributor

daall commented May 6, 2020

retest this please

@prsunny prsunny merged commit 057c72a into sonic-net:master May 6, 2020
@prsunny prsunny deleted the vnet_cli branch May 6, 2020 19:37
rlhui pushed a commit that referenced this pull request May 10, 2020
* Fix NameError for 'swsssdk', align neig output
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
* Fix NameError for 'swsssdk', align neig output
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[Vnet] Fix NameError for 'swsssdk' and align output (sonic-net#902)
[config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904)
Improved route_check tool and adopt to 20191130 image. (sonic-net#898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants