[show] Fix abbreviations for 'show ip bgp ...' commands#901
Merged
jleveque merged 1 commit intosonic-net:masterfrom May 4, 2020
jleveque:fix_bgp_abbrev
Merged
[show] Fix abbreviations for 'show ip bgp ...' commands#901jleveque merged 1 commit intosonic-net:masterfrom jleveque:fix_bgp_abbrev
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:fix_bgp_abbrev
Conversation
prsunny
approved these changes
May 3, 2020
qiluo-msft
approved these changes
May 3, 2020
Contributor
|
@jleveque, there's conflict. please raise a separate PR for 201911 branch. |
Contributor
Author
|
Opened separate PR against 201911 branch here: #909 |
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
AliasedGroupclass in show/main.py handles finding a subcommand to run based on an abbreviation. Thus, we need to import in the bgp files and use it as the base class for the 'bgp' groups in order to allow abbreviations to work for the subcommands in these groups.