Merged
Conversation
|
@taoyl-ms, |
lguohan
reviewed
Jul 19, 2017
config/main.py
Outdated
| def _get_bgp_asn_from_minigraph(): | ||
| # Get BGP ASN from minigraph | ||
| proc = subprocess.Popen([SONIC_CFGGEN_PATH, '-m', MINIGRAPH_PATH, '--var-json', MINIGRAPH_BGP_ASN_KEY], | ||
| # Returns BGP neighbor dict from minigraph |
Contributor
There was a problem hiding this comment.
better to move the comments as python doc.
Contributor
|
|
lguohan
approved these changes
Jul 19, 2017
jleveque
approved these changes
Jul 19, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
As part of the migration from Python 2 to Python 3, this PR ensures that all Python files in sonic-platform-daemons are Python 3-compliant, and work with both Python 2 and Python 3. Once this is merged, we can begin building Python 3-based versions of the sonic-platform-daemons packages.
stepanblyschak
referenced
this pull request
in stepanblyschak/sonic-utilities
Apr 28, 2022
e466ac226c48cf87f83aa5564efd7155ac97a0c1 (HEAD -> master, origin/master, origin/HEAD) Reject incorrect CIDR addresses while configuring routes (#91) 07cf59d866914ef7cb6901d51f289f0bee721e44 [CI] Set up Azure pipeline (#89) 47476acdfaf668ab0cd9ae2443205a3bdc2e9ef9 Upgrade Go version to 1.14 (#90) ee887c785c10d8b4f70db90ca50cc398327c5d73 Added flag to make go/pkg/ folder writable (removable) (#87) 6cfc8fe110c46a1ee5a8430e02a440b5a7b4006d (origin/shilongliu/azp) Default Vrf static route support (#85) d3e8b8e4aee278fa11d7d86acabdab3fffc70d5a Add BFD config to subinterface and neighbor (#68) 8d4fd4a56b637d3b7403c321aef36b8dff58cd62 Fix WS-2018-0594 potential non-random UUIDs security issue (#78) fad87fa20f6b15e28c90e02a131c44d236d6a751 Update API description for default vrf and ecmp routes (#82) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Handling the IOError produced during interacting with the eeprom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For BGP admin status, CLI will now only write config into DB, and config daemon in bgp docker will do actual config job.