[mellanox] enable watchdog before fast-reboot#844
Merged
yxieca merged 2 commits intosonic-net:201811from Apr 30, 2020
Merged
Conversation
On newer CPLDs this script will enabled hardware watchdog and set timeout to 600 sec. On older CPLDs this script will fail saying it does not support mellanox watchdog type 1, however fast-reboot won't fail as by the time this script is called all services are down, so better to do fast reboot any way as it was before rathen then failing the whole fast reboot process and leaving system in failed state. Signed-off-by: Stepan Blyschak <[email protected]>
Contributor
Author
|
retest this please |
qiluo-msft
requested review from
jleveque and
sujinmkang
and removed request for
sujinmkang
jleveque
approved these changes
Mar 31, 2020
sujinmkang
approved these changes
Apr 1, 2020
Collaborator
|
retest this please |
4 similar comments
Collaborator
|
retest this please |
Collaborator
|
retest this please |
Contributor
|
retest this please |
Collaborator
|
retest this please |
sujinmkang
reviewed
Apr 23, 2020
scripts/watchdog
Outdated
| debug "Calling MLNX WD enable" | ||
| # call watchdog api for mlnx | ||
| if [[ -x /usr/bin/hw-management-wd.sh ]]; then | ||
| /usr/bin/hw-management-wd.sh start |
Collaborator
There was a problem hiding this comment.
Stepan, can you please change this to pass the 3 minutes watchdog timer setting as you mentioned in sonic-net/sonic-buildimage#4452.
hw-management-wd.sh start 180
Collaborator
There was a problem hiding this comment.
I will close my PR on sonic-buildimage
Contributor
|
I think the tests are failing because this PR is based on the 201811 branch, which doesn't have any NAT CLI commands in it. The other tests look to be passing consistently. @lguohan |
Signed-off-by: Stepan Blyschak <[email protected]>
Collaborator
|
@lguohan can we merge this change? |
Collaborator
|
Retest this please |
Contributor
|
All failures are NAT related. Not related to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On newer CPLDs this script will enabled hardware watchdog and set timeout
to 600 sec. On older CPLDs this script will fail saying it does not
support mellanox watchdog type 1, however fast-reboot won't fail as by
the time this script is called all services are down, so better to do
fast reboot any way as it was before rathen then failing the whole fast
reboot process and leaving system in failed state.
Signed-off-by: Stepan Blyschak [email protected]
DEPENDS sonic-net/sonic-buildimage#4274
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)