Skip to content

[fwutil]: Set default socket timeout for FW download to 30 sec#821

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
nazariig:master-fwutil-bugfix
Mar 1, 2020
Merged

[fwutil]: Set default socket timeout for FW download to 30 sec#821
liat-grozovik merged 1 commit intosonic-net:masterfrom
nazariig:master-fwutil-bugfix

Conversation

@nazariig
Copy link
Copy Markdown
Collaborator

Signed-off-by: Nazarii Hnydyn [email protected]

- What I did

  • Fixed CLI endless wait when installing FW from URL and network goes down

- How I did it

  • Added default socket 30 sec timeout

- How to verify it

  1. Connect to switch via serial console
  2. Start FW installation form URL
  3. Shutdown management interface
root@sonic:/home/admin# fwutil install chassis component BIOS fw http://sonic-server/fwutil/bios/x86_64-mlnx_msn3800-r0_latest/0ACLH004.rom
New firmware will be installed, continue? [y/N]: y
Downloading firmware:
    [#-------------------------------------------------------------------]    2%
Error: timed out. Aborting...
Aborted!

root@sonic:/home/admin# cat /var/log/syslog | grep fwutil
Feb 25 15:06:20.718495 sonic INFO fwutil: Firmware download started: component=x86_64-mlnx_msn3800-r0/BIOS, firmware=http://sonic-server/fwutil/bios/x86_64-mlnx_msn3800-r0_latest/0ACLH004.rom
Feb 25 15:06:50.770669 sonic ERR fwutil: Firmware download ended: component=x86_64-mlnx_msn3800-r0/BIOS, firmware=http://sonic-server/fwutil/bios/x86_64-mlnx_msn3800-r0_latest/0ACLH004.rom, status=failure, exception=timed out

- Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# fwutil install chassis component BIOS fw http://sonic-server/fwutil/bios/x86_64-mlnx_msn3800-r0_latest/0ACLH004.rom
New firmware will be installed, continue? [y/N]: y
Downloading firmware:
    [#-------------------------------------------------------------------]    2%

- New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# fwutil install chassis component BIOS fw http://sonic-server/fwutil/bios/x86_64-mlnx_msn3800-r0_latest/0ACLH004.rom
New firmware will be installed, continue? [y/N]: y
Downloading firmware:
    [#-------------------------------------------------------------------]    2%
Error: timed out. Aborting...
Aborted!

@svc-acs
Copy link
Copy Markdown
Collaborator

svc-acs commented Feb 25, 2020

Build finished. 248 tests run, 10 skipped, 1 failed.

@nazariig
Copy link
Copy Markdown
Collaborator Author

@sujinmkang please have a look

@nazariig
Copy link
Copy Markdown
Collaborator Author

retest this please

@liat-grozovik liat-grozovik merged commit c5c5ffc into sonic-net:master Mar 1, 2020
abdosi pushed a commit that referenced this pull request Mar 4, 2020
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
[fwutil]: Set default socket timeout for FW download to 30 sec. (sonic-net#821)
Update config/show to include PFC Watchdog commands (sonic-net#736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants