[fwutil]: Command-line utility for interacting with platform components by nazariig · Pull Request #772 · sonic-net/sonic-utilities

nazariig · 2019-12-18T18:57:38Z

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

fwutil HLD: sonic-net/SONiC#463

- What I did

Introduced fwutil

- How I did it

Implemented CLI

- How to verify it

fwutil show status
fwutil install chassis component <component_name> fw <fw_path> -y
fwutil install module <module_name> component <component_name> fw <fw_path> -y
fwutil update -y

- Previous command output (if the output of a command-line utility has changed)

N/A

- New command output (if the output of a command-line utility has changed)

N/A

liat-grozovik · 2019-12-24T09:11:51Z

retest this please

nazariig · 2020-01-02T16:46:13Z

@sujinmkang please have a look.

nazariig · 2020-01-02T16:47:46Z

@lguohan please have a look.

nazariig · 2020-01-09T17:36:44Z

@mudsut4ke please have a look.

nazariig · 2020-01-15T17:58:55Z

retest this please

sujinmkang · 2020-01-21T22:10:00Z

retest this please

sujinmkang · 2020-01-22T02:23:27Z

retest this please

sujinmkang · 2020-01-27T21:45:36Z

retest this please

daall · 2020-01-29T03:06:05Z

retest this please

liat-grozovik

Missing command reference update with the new commands.

jleveque · 2020-01-30T00:56:44Z

@liat-grozovik: Do we want to add these commands to the Command Reference, or do we intend to wrap these commands in show/config commands?

nazariig · 2020-02-05T12:22:41Z

Missing command reference update with the new commands.

@liat-grozovik The CLI reference does not provide the description for the low level tools:
https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md#introduction
sonic-clear, sfputil, etc., This document does not explain these scripts also.

nazariig · 2020-02-07T13:04:39Z

retest this please

doc/Command-Reference.md

jleveque · 2020-02-10T19:02:06Z

Please fix new conflicts.

doc/Command-Reference.md

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

nazariig · 2020-02-11T18:29:31Z

Please fix new conflicts.

@jleveque done

jleveque · 2020-02-11T19:07:08Z

LGTM. @sujinmkang to review as well.

nazariig · 2020-02-12T09:12:50Z

@sujinmkang please have a look

sujinmkang

This looks good to me.

jleveque · 2020-02-18T08:05:46Z

Merging is blocked because @liat-grozovik has an unresolved requested change.

…ts (#772) * [fwutil]: initial version. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Fix UI: enable progressbar render finalizer. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: integrate utility with SONiC CLI. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: update CLI command reference documentation. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Revisit CLI architecture: avoid direct imports. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Fix review comments: refactor CLI command reference. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Fix review comments: update CLI documentation. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

…ts (sonic-net#772) * [fwutil]: initial version. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Fix UI: enable progressbar render finalizer. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: integrate utility with SONiC CLI. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: update CLI command reference documentation. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Revisit CLI architecture: avoid direct imports. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Fix review comments: refactor CLI command reference. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com> * [fwutil]: Fix review comments: update CLI documentation. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

nazariig mentioned this pull request Dec 18, 2019

Added fwutil High Level Design sonic-net/SONiC#463

Merged

liat-grozovik requested review from jleveque, liat-grozovik and sujinmkang December 23, 2019 13:29

jleveque previously approved these changes Dec 30, 2019

View reviewed changes

nazariig dismissed jleveque’s stale review via a98bea4 January 2, 2020 12:24

nazariig mentioned this pull request Jan 9, 2020

[mellanox] Add fwutil platform components files sonic-net/sonic-buildimage#3999

Merged

srideepDell previously approved these changes Jan 15, 2020

View reviewed changes

liat-grozovik approved these changes Jan 29, 2020

View reviewed changes

liat-grozovik requested changes Jan 29, 2020

View reviewed changes

nazariig dismissed srideepDell’s stale review via 7e81829 February 7, 2020 12:55

nazariig force-pushed the master-add-fwutil branch from a98bea4 to 7e81829 Compare February 7, 2020 12:55

nazariig requested review from jleveque, lguohan and liat-grozovik February 7, 2020 14:59

jleveque suggested changes Feb 7, 2020

View reviewed changes

doc/Command-Reference.md Outdated Show resolved Hide resolved

nazariig requested a review from jleveque February 10, 2020 17:11

liat-grozovik reviewed Feb 11, 2020

View reviewed changes

doc/Command-Reference.md Outdated Show resolved Hide resolved

doc/Command-Reference.md Outdated Show resolved Hide resolved

doc/Command-Reference.md Outdated Show resolved Hide resolved

nazariig added 6 commits February 11, 2020 09:32

[fwutil]: initial version.

8c0e02b

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

[fwutil]: Fix UI: enable progressbar render finalizer.

6d2060f

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

[fwutil]: integrate utility with SONiC CLI.

461a609

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

[fwutil]: update CLI command reference documentation.

9751a8e

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

[fwutil]: Revisit CLI architecture: avoid direct imports.

b10d27e

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

[fwutil]: Fix review comments: refactor CLI command reference.

ae1463e

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

nazariig force-pushed the master-add-fwutil branch from c3605aa to 9e53117 Compare February 11, 2020 09:54

[fwutil]: Fix review comments: update CLI documentation.

bf81c6f

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

nazariig force-pushed the master-add-fwutil branch from 9e53117 to bf81c6f Compare February 11, 2020 10:01

sujinmkang approved these changes Feb 18, 2020

View reviewed changes

jleveque approved these changes Feb 18, 2020

View reviewed changes

jleveque added the Enhancement label Feb 18, 2020

liat-grozovik approved these changes Feb 20, 2020

View reviewed changes

liat-grozovik merged commit 659a935 into sonic-net:master Feb 20, 2020

liat-grozovik added the Request for 201911 Branch label Feb 20, 2020

abdosi added the Included in 201911 Branch label Feb 24, 2020

Conversation

nazariig commented Dec 18, 2019

Uh oh!

liat-grozovik commented Dec 24, 2019

Uh oh!

nazariig commented Jan 2, 2020

Uh oh!

nazariig commented Jan 2, 2020

Uh oh!

nazariig commented Jan 9, 2020

Uh oh!

nazariig commented Jan 15, 2020

Uh oh!

sujinmkang commented Jan 21, 2020

Uh oh!

sujinmkang commented Jan 22, 2020

Uh oh!

sujinmkang commented Jan 27, 2020

Uh oh!

daall commented Jan 29, 2020

Uh oh!

liat-grozovik left a comment

Choose a reason for hiding this comment

Uh oh!

jleveque commented Jan 30, 2020

Uh oh!

nazariig commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nazariig commented Feb 7, 2020

Uh oh!

Uh oh!

jleveque commented Feb 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nazariig commented Feb 11, 2020

Uh oh!

jleveque commented Feb 11, 2020

Uh oh!

nazariig commented Feb 12, 2020

Uh oh!

sujinmkang left a comment

Choose a reason for hiding this comment

Uh oh!

jleveque commented Feb 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nazariig commented Feb 5, 2020 •

edited

Loading