Do not start pfcwd for M0 devices#726
Merged
yxieca merged 2 commits intosonic-net:masterfrom Nov 7, 2019
Merged
Conversation
Signed-off-by: Neetha John <nejo@microsoft.com>
yxieca
reviewed
Nov 6, 2019
prsunny
reviewed
Nov 6, 2019
| run_command(command, display_cmd=True) | ||
| client.set(config_db.INIT_INDICATOR, 1) | ||
| run_command('pfcwd start_default', display_cmd=True) | ||
| if device_type != 'MgmtToRRouter': |
Contributor
There was a problem hiding this comment.
Isn't it better to check if device_type contains 'Mgmt' ?
Contributor
Author
There was a problem hiding this comment.
as per our discussion, leaving this as is
Signed-off-by: Neetha John <nejo@microsoft.com>
prsunny
approved these changes
Nov 7, 2019
yxieca
approved these changes
Nov 7, 2019
Contributor
|
retest this please |
yxieca
pushed a commit
that referenced
this pull request
Nov 7, 2019
* Do not start pfcwd for M0 devices Signed-off-by: Neetha John <nejo@microsoft.com> * Avoid exiting for device type error Signed-off-by: Neetha John <nejo@microsoft.com>
yxieca
added
included_in_configlet_201811
Included in 201811 Branch
and removed
included_in_configlet_201811
labels
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
e98a7af95a9767093904d9e8fd320067163d5f87 (HEAD -> 201911, origin/201911) [syncd] Translate removed RIDs in fdb notification (sonic-net#729) 3ceeae5371eee5b69064fa1af88f51e27caa2d36 [syncd] Process all cases fdb flush notification (sonic-net#726) 115ba0783edf85658fd0329eb23796d758c309f5 fix compile error when compiling with g++-4.8.4 (sonic-net#718) a67f94d3d91325516069ef8c0d99bdec30bafbce Fix typo at SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_UINT32 (sonic-net#662) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
- What I did
Disable pfcwd for M0 devices
- How I did it
Get the device type from the minigraph and use that for comparison
- How to verify it