sfpshow: prevent 'show int trans eeprom --dom' from crashing#567
Merged
jleveque merged 1 commit intosonic-net:masterfrom Jul 25, 2019
ds952811:SONIC-5279-DOM
Merged
sfpshow: prevent 'show int trans eeprom --dom' from crashing#567jleveque merged 1 commit intosonic-net:masterfrom ds952811:SONIC-5279-DOM
jleveque merged 1 commit intosonic-net:masterfrom
ds952811:SONIC-5279-DOM
Conversation
When some specific 25G DAC attached to the system, the 'dom_info_dict' could be a None object, as a result, the 'show int transceiver eeprom --dom' will crash. And thus, in this commit, we'll add an additional checker for the None object. Signed-off-by: Dante (Kuo-Jung) Su <[email protected]> Change-Id: Ic2b5eb38ddf98b98cce7eddf161595013a19c720
stcheng
approved these changes
Jul 2, 2019
jleveque
approved these changes
Jul 2, 2019
Contributor
|
Retest this please |
3 similar comments
Contributor
|
Retest this please |
Contributor
|
Retest this please |
Contributor
|
Retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When some specific 25G DAC attached to the system, the 'dom_info_dict'
could be a None object, as a result, the 'show int transceiver eeprom --dom'
will crash.
And thus, in this commit, we'll add an additional checker for the None object.
Signed-off-by: Dante (Kuo-Jung) Su [email protected]
Change-Id: Ic2b5eb38ddf98b98cce7eddf161595013a19c720
- What I did
Add a None object checker to prevent CLI from crashing
- How I did it
Add a None object checker
- How to verify it
Attach a 25G DAC to the system
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->