[show] show interface status added vlan and portchannels to command#483
Merged
jleveque merged 5 commits intosonic-net:masterfrom Mar 21, 2019
Merged
Conversation
tsvanduyn
changed the title
jleveque
suggested changes
Mar 13, 2019
jleveque
reviewed
Mar 18, 2019
jleveque
suggested changes
Mar 19, 2019
Contributor
|
What is the output if interface is member of multiple Vlans? |
Contributor
|
@tsvanduyn: Can you please update the new command output in the description above to reflect your latest change? |
Contributor
Author
|
Here is what the new output would look like: PortChannel0001 N/A 40G 9100 N/A routed down up N/A N/A |
Contributor
|
@tsvanduyn: please update the output in the description of the PR to reflect the new change, because it currently doesn't match. |
Contributor
Author
|
@jleveque I've updated the description. Thanks Travis. |
jleveque
approved these changes
Mar 19, 2019
Contributor
|
Retest this please |
fgggid
reviewed
Apr 29, 2019
| elif intf_name.startswith('Ethernet'): | ||
| appl_db_keys = appl_db.keys(appl_db.APPL_DB, "PORT_TABLE:%s" % intf_name) | ||
| elif intf_name in front_panel_ports_list: | ||
| appl_db_keys = db.keys(appl_db.APPL_DB, "PORT_TABLE:%s" % intf_name) |
yxieca
pushed a commit
that referenced
this pull request
May 30, 2019
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Include below commits sonic-swss-common ``` 83d3351 2021-04-22 | [swig] fix ConfigDBConnector.db_name (sonic-net#483) [Qi Luo] fdf296f 2021-04-09 | Fix: ConfigDBConnector call super init with proper parameter name (sonic-net#470) [Qi Luo] 4f580e3 2021-03-26 | [swig] translate SonicV2Connector::keys return type from C++ vector<string> to Python list (sonic-net#468) [Qi Luo] ``` sonic-snmpagent ``` c160c2b 2021-08-04 | CPU Spike because of redundant and flooded keyspace notifis handled (sonic-net#230) [Vivek Reddy] a4dd3bf 2021-08-03 | Non-block reading counters to tolerate corrupted/delayed counters in COUNTERS_DB (sonic-net#231) [Qi Luo] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Updated the file to add a "VLAN" column that reports "routed",
"VlanXXXX""trunk", or "PortChannelXXXX" depending on how that interface is configured. This is how Arista/Cisco report on this command.Also added PortChannels to the bottom on the command like Cisco/Arista.
- How I did it
Updated the intfutil file to add additonal methods to support this.
- How to verify it
run the "show int status" command on the sonic systems.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)