[ CLI ]Refactor show interface transceiver cli command#471
Merged
jleveque merged 6 commits intosonic-net:masterfrom Mar 11, 2019
keboliu:refactor-show-sfp
Merged
[ CLI ]Refactor show interface transceiver cli command#471jleveque merged 6 commits intosonic-net:masterfrom keboliu:refactor-show-sfp
jleveque merged 6 commits intosonic-net:masterfrom
keboliu:refactor-show-sfp
Conversation
merge from Azure mater
merge from master
keboliu
changed the title
Collaborator
Author
|
retest this please |
jleveque
reviewed
Feb 26, 2019
jleveque
approved these changes
Feb 28, 2019
Contributor
|
Please address new conflicts. |
Collaborator
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a dependency on sonic-net/sonic-platform-common#22 and sonic-net/sonic-platform-daemons#24
- What I did
Refactor "show interface transceiver eeprom" and "show interface transceiver presence" to get data from state db instead of access hw directly.
Detail info please refer to the design doc: https://github.com/Azure/SONiC/blob/master/doc/pmon/pmon-enhancement-design.md
also add cli vs test for these two commands.
- How I did it
Add a new scripts "sfpshow", in this scripts get sfp data from state db and convert it to cli output.
- How to verify it
run these two cli on sonic switch.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)