[202511][cherry-pick] Fix show ip route json and show ipv6 route json when there is no IPv4 or IPv6 route#4363
Merged
vmittal-msft merged 1 commit intosonic-net:202511from Mar 17, 2026
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PriyanshTratiya
changed the title
show ip route json and show ipv6 route json when there is no IPv4 or IPv6 route
…IPv4 or IPv6 route (sonic-net#4177) * remove early return Signed-off-by: BYGX-wcr <[email protected]> * add unit tests for IP4 only and IP6 only scenarios Signed-off-by: BYGX-wcr <[email protected]> * fix incorrect UT data format Signed-off-by: BYGX-wcr <[email protected]> * fix UT data Signed-off-by: BYGX-wcr <[email protected]> * add early return for non-json case Signed-off-by: BYGX-wcr <[email protected]> --------- Signed-off-by: BYGX-wcr <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>
PriyanshTratiya
force-pushed
the
cherry-pick-4177-to-202511
branch
from
c214895 to
ac0d5d4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual Cherry Pick: #4177
dependent on: #4362
MSFT ADO: 36173805
What I did
I change the output format from "" to "{}" of
show ip route jsonandshow ipv6 route jsonwhen there is no IPv4 or IPv6 route.The reason why I did this is because "" is not a valid json string. Any application (such as route_check.py) uses the output of this command as a json string will encounter a JSON parsing error when the output is empty.
How I did it
I restricted the early termination in bgp_common.show_routes when the combined route is empty to the non-json case only.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)