[202511: WRED/ECN] Cherry-pick PR https://github.com/sonic-net/sonic-utilities/pull/4152…#4328
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: saksarav <[email protected]>
saksarav-nokia
force-pushed
the
saksarav-nokia-wred-201511
branch
from
46ee9eb to
9773ed2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saksarav-nokia
changed the title
saksarav-nokia
changed the title
| type=click.Choice(multi_asic.get_namespace_list())) | ||
| @click.pass_context | ||
| def phy(ctx): | ||
| def phy(ctx, namespace): |
There was a problem hiding this comment.
This change was not present in the original PR and is not currently found in master
https://github.com/sonic-net/sonic-utilities/blame/master/counterpoll/main.py#L175
Are these phy counters supposed to be scoped to a namespace?
There was a problem hiding this comment.
This change was not present in the original PR and is not currently found in master https://github.com/sonic-net/sonic-utilities/blame/master/counterpoll/main.py#L175
Are these phy counters supposed to be scoped to a namespace?
@peterbailey-arista , The PR had lot of changes and conflicts. Let me check if the cherry-pick messed up anything and create a PR to fix it
There was a problem hiding this comment.
This change was not present in the original PR and is not currently found in master https://github.com/sonic-net/sonic-utilities/blame/master/counterpoll/main.py#L175
Are these phy counters supposed to be scoped to a namespace?@peterbailey-arista , The PR had lot of changes and conflicts. Let me check if the cherry-pick messed up anything and create a PR to fix it
@peterbailey-arista , Checked this PR and yes, the changes not there in master. When i originally created my PR 4152 in master, the phy commands were not present and when i cherry-picked, i noticed and fixed them as well. I will create a PR for master to add multi-asic support. Thanks for catching this.
4 participants
What I did
Cherry-pick #4152 from master to 202511 since it had conflicts
How I did it
Cherry-picked and verified the cli commands
How to verify it
Verified that all the modified commands are working
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)