Skip to content

[action] [PR:4206] [sfputil] Fix issue: should not do low power mode or reset for non-present ports#4241

Merged
mssonicbld merged 1 commit intosonic-net:202511from
mssonicbld:cherry/202511/4206
Feb 2, 2026
Merged

[action] [PR:4206] [sfputil] Fix issue: should not do low power mode or reset for non-present ports#4241
mssonicbld merged 1 commit intosonic-net:202511from
mssonicbld:cherry/202511/4206

Conversation

@mssonicbld
Copy link
Collaborator

What I did

Ignore get_lpmode, set_lpmode, reset for ports that with no module present

How I did it

Check module presence before calling get_lpmode, set_lpmode, reset

How to verify it

New unit test - PASSED
Manual test - PASSED

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…esent ports

<!--
    Please make sure you've read and understood our contributing guidelines:
    https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

    ** Make sure all your commits include a signature generated with `git commit -s` **

    If this is a bug fix, make sure your description includes "closes #xxxx",
    "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
    issue when the PR is merged.

    If you are adding/modifying/removing any command or utility script, please also
    make sure to add/modify/remove any unit tests from the tests
    directory as appropriate.

    If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
    subcommand, or you are adding a new subcommand, please make sure you also
    update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
    your changes.

    Please provide the following information:
-->

#### What I did

Ignore get_lpmode, set_lpmode, reset for ports that with no module present

#### How I did it

Check module presence before calling get_lpmode, set_lpmode, reset

#### How to verify it

New unit test - PASSED
Manual test - PASSED

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
@mssonicbld
Copy link
Collaborator Author

Original PR: #4206

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 529b647 into sonic-net:202511 Feb 2, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant