Skip to content

[GCU] Update WRED_PROFILE and BUFFER_POOL validators for GCU #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 8 commits into from
Jan 27, 2026
Merged

[GCU] Update WRED_PROFILE and BUFFER_POOL validators for GCU #4219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
194a013
Update WRED_PROFILE and BUFFER_POOL validators
developfast Jan 24, 2026
18b49bd
revert min os version change
developfast Jan 27, 2026
368c091
add unit tests for non-validator tables
developfast Jan 27, 2026
f1ceb39
remove orphaned wred code
developfast Jan 27, 2026
cf99b57
add more unit tests
developfast Jan 27, 2026
3999c54
flake8 fix
developfast Jan 27, 2026
ba885de
add all fields for wred changes
developfast Jan 27, 2026
3c4bac2
add more port qos unit tests
developfast Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions generic_config_updater/field_operation_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,6 @@ def buffer_profile_config_update_validator(scope, patch_element):
return rdma_config_update_validator_common(scope, patch_element)


def wred_profile_config_update_validator(scope, patch_element):
return rdma_config_update_validator_common(scope, patch_element)


def read_statedb_entry(scope, table, key, field):
state_db = swsscommon.DBConnector(STATE_DB_NAME, REDIS_TIMEOUT_MSECS, True, scope)
tbl = swsscommon.Table(state_db, table)
Expand Down
56 changes: 1 addition & 55 deletions generic_config_updater/gcu_field_operation_validators.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,29 +87,9 @@
"rdma_config_update_validator": {
"Shared/headroom pool size changes": {
"fields": [
"ingress_lossless_pool/xoff",
"ingress_lossless_pool/size",
"egress_lossy_pool/size"
],
"operations": ["replace"],
"operations": [],
"platforms": {
"spc1": "20191100",
"spc2": "20191100",
"spc3": "20220500",
"spc4": "20221100",
"spc5": "20241200",
"td2": "",
"th": "20221100",
"th2": "20221100",
"th3": "20240500",
"th4": "20240500",
"th5": "20240500",
"td3": "20221100",
"td4": "20241100",
"q2c+": "20241100",
"j2c+": "20220500",
"q3d": "20251100",
"cisco-8000": "20201200"
}
}
}
Expand Down Expand Up @@ -193,40 +173,6 @@
}
}
},
"WRED_PROFILE": {
"field_operation_validators": [ "generic_config_updater.field_operation_validators.wred_profile_config_update_validator" ],
"validator_data": {
"rdma_config_update_validator": {
"ECN tuning": {
"fields": [
"green_min_threshold",
"green_max_threshold",
"green_drop_probability"
],
"operations": ["replace"],
"platforms": {
"spc1": "20181100",
"spc2": "20191100",
"spc3": "20220500",
"spc4": "20221100",
"spc5": "20241200",
"td2": "20181100",
"th": "20181100",
"th2": "20181100",
"th3": "20240500",
"th4": "20240500",
"th5": "20240500",
"td3": "20201200",
"td4": "20241100",
"q2c+": "20241100",
"j2c+": "20220500",
"q3d": "20251100",
"cisco-8000": "20201200"
}
}
}
}
},
"PORT": {
"field_operation_validators": [ "generic_config_updater.field_operation_validators.port_config_update_validator" ]
}
Expand Down
Loading
Loading