Add multi-asic support for mirror capability check#4218
Closed
saksarav-nokia wants to merge 4 commits intosonic-net:masterfrom
Closed
Add multi-asic support for mirror capability check#4218saksarav-nokia wants to merge 4 commits intosonic-net:masterfrom
saksarav-nokia wants to merge 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@stephenxs pls review |
Contributor
Author
|
@arlakshm pls review |
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
saksarav-nokia
force-pushed
the
saksara-nokia-mirror
branch
from
9c20416 to
22518a4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
closing this PR since #4159 already addressed this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the issue reported in sonic-net/sonic-buildimage#25162
In PR #4089, the code was added to check the mirror capability in STATE_DB for both ingress and egress mirror when the mirror session is configured. But this PR doesn't handle the multi-asic systems and hence it checks the capability in the global namespace and hence the mirror configuration fails for multi-asic systems.
Added code to pass the correct namespace and check the mirror capability in that corresponding asic namespace's STATE_DB
How I did it
n PR #4089, the code was added to check the mirror capability in STATE_DB for both ingress and egress mirror when the mirror session is configured. But this PR doesn't handle the multi-asic systems and hence it checks the capability in the global namespace and hence the mirror configuration fails for multi-asic systems.
Added code to pass the correct namespace and check the mirror capability in that corresponding asic namespace's STATE_DB
How to verify it
Verified the mirror configuration in multis-asic systems.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)