[bash_completion.d] Update completion for newer click#4213
Closed
cpackham-atlnz wants to merge 1 commit intosonic-net:masterfrom
Closed
[bash_completion.d] Update completion for newer click#4213cpackham-atlnz wants to merge 1 commit intosonic-net:masterfrom
cpackham-atlnz wants to merge 1 commit intosonic-net:masterfrom
Conversation
As of click 8.0.0 the way shell completion works for bash hash changed. Update the completion files for the new method. Fixes sonic-net#4211 Signed-off-by: Chris Packham <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
Is there someone that can review this @prsunny @liat-grozovik @Blueve ? Not actually sure who to ask. |
Author
|
Looks like this is obsoleted by other changes |
|
@cpackham-atlnz Why this PR was closed? The issue still exists. Are there any other fixes which addressed issue #4211 |
Author
|
@sspeedy99 this was obsoleted by #4163 and sonic-net/sonic-build-image#25912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of click 8.0.0 the way shell completion works for bash hash changed. Update the completion files for the new method.
Fixes #4211