Add current and configured frequency to DOM CLI#4207
Add current and configured frequency to DOM CLI#4207az-pz wants to merge 5 commits intosonic-net:masterfrom
Conversation
|
/azp run |
az-pz
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@az-pz Can you please add the CLI output for different types of transceivers? |
There was a problem hiding this comment.
Pull request overview
This pull request adds support for displaying current and configured laser frequencies in the DOM (Digital Optical Monitoring) CLI interface. The changes enable users to view laser frequency information alongside existing temperature and voltage data when querying transceiver status.
Changes:
- Added two new laser frequency fields ('laser_curr_freq' and 'laser_config_freq') to the DOM module monitor display
- Updated both the display name mapping (DOM_MODULE_MONITOR_MAP) and unit mapping (DOM_VALUE_UNIT_MAP) to support the new fields with GHz units
Comments suppressed due to low confidence (1)
scripts/sfpshow:221
- The new laser frequency fields ('laser_curr_freq' and 'laser_config_freq') should be added to QSFP_DD_DOM_VALUE_UNIT_MAP for consistency with DOM_VALUE_UNIT_MAP. While these fields are currently used in DOM_MODULE_MONITOR_MAP (module-level monitoring), adding them to QSFP_DD_DOM_VALUE_UNIT_MAP ensures consistency across all unit maps and prevents potential issues if these fields are ever used in CMIS channel monitoring contexts. Both fields should be added with the unit 'GHz' to match the entries in DOM_VALUE_UNIT_MAP.
QSFP_DD_DOM_VALUE_UNIT_MAP = {
'rx1power': 'dBm',
'rx2power': 'dBm',
'rx3power': 'dBm',
'rx4power': 'dBm',
'rx5power': 'dBm',
'rx6power': 'dBm',
'rx7power': 'dBm',
'rx8power': 'dBm',
'tx1bias': 'mA',
'tx2bias': 'mA',
'tx3bias': 'mA',
'tx4bias': 'mA',
'tx5bias': 'mA',
'tx6bias': 'mA',
'tx7bias': 'mA',
'tx8bias': 'mA',
'tx1power': 'dBm',
'tx2power': 'dBm',
'tx3power': 'dBm',
'tx4power': 'dBm',
'tx5power': 'dBm',
'tx6power': 'dBm',
'tx7power': 'dBm',
'tx8power': 'dBm',
'temperature': 'C',
'voltage': 'Volts'
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DOM_MODULE_MONITOR_MAP = { | ||
| 'temperature': 'Temperature', | ||
| 'voltage': 'Vcc' | ||
| 'voltage': 'Vcc', | ||
| 'laser_curr_freq': 'Requested Laser Frequency', | ||
| 'laser_config_freq': 'Tx Frequency' | ||
| } |
There was a problem hiding this comment.
The Command Reference documentation should be updated to include the new laser frequency fields in the ModuleMonitorValues section. The example output in doc/Command-Reference.md (around line 1190-1192) should show the new 'Requested Laser Frequency' and 'Tx Frequency' fields alongside Temperature and Vcc to reflect the changes made to the DOM CLI output.
az-pz
force-pushed
the
ariz/add-current-and-configured-frequency-to-dom-cli
branch
from
560e15e to
3db2d62
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
az-pz
force-pushed
the
ariz/add-current-and-configured-frequency-to-dom-cli
branch
from
3db2d62 to
5f79bae
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
az-pz
force-pushed
the
ariz/add-current-and-configured-frequency-to-dom-cli
branch
from
5f79bae to
9b89a5c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing this pull request. Created a new PR (#4209 ) with a new branch with clean commit history. |
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
For 400 ZR optic:
show int trans eeprom Ethernet0 -d Ethernet0: SFP EEPROM detected Active Firmware: 3.3.36 Active application selected code assigned to host lane 1: 1 Active application selected code assigned to host lane 2: 1 Active application selected code assigned to host lane 3: 1 Active application selected code assigned to host lane 4: 1 Active application selected code assigned to host lane 5: 1 Active application selected code assigned to host lane 6: 1 Active application selected code assigned to host lane 7: 1 Active application selected code assigned to host lane 8: 1 Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - 400ZR, DWDM, amplified - Media Assign (0x1) 100GAUI-2 C2M (Annex 135G) - Host Assign (0x55) - 400ZR, DWDM, amplified - Media Assign (0x1) CMIS Rev: 5.0 Connector: LC Encoding: N/A Extended Identifier: Power Class 8 (18.0W Max) Extended RateSelect Compliance: N/A Host Lane Count: 8 Identifier: QSFP-DD Double Density 8X Pluggable Transceiver Inactive Firmware: 3.3.36 Length Cable Assembly(m): 0.0 Media Interface Technology: C-band tunable laser Media Lane Count: 1 Module Hardware Rev: 0.0 Nominal Bit Rate(100Mbs): N/A Specification compliance: sm_media_interface Supported Max Laser Frequency: 196100 Supported Max TX Power: -8.5 Supported Min Laser Frequency: 191300 Supported Min TX Power: -14.0 Vendor Date Code(YYYY-MM-DD Lot): 2024-01-20 Vendor Name: INPHI CORP Vendor OUI: 00-21-b8 Vendor PN: IN-Q3JZ1-TC-M1 Vendor Rev: 01 Vendor SN: L2403D0925C is_replaceable: True type_abbrv_name: QSFP-DD vdm_supported: True ChannelMonitorValues: RX1Power: -8.735dBm RX2Power: -infdBm RX3Power: -infdBm RX4Power: -infdBm RX5Power: -infdBm RX6Power: -infdBm RX7Power: -infdBm RX8Power: -infdBm TX1Bias: 208.0mA TX1Power: -8.499dBm TX2Bias: 0.0mA TX2Power: -infdBm TX3Bias: 0.0mA TX3Power: -infdBm TX4Bias: 0.0mA TX4Power: -infdBm TX5Bias: 0.0mA TX5Power: -infdBm TX6Bias: 0.0mA TX6Power: -infdBm TX7Bias: 0.0mA TX7Power: -infdBm TX8Bias: 0.0mA TX8Power: -infdBm ChannelThresholdValues: RxPowerHighAlarm : 2.0dBm RxPowerHighWarning: 0.0dBm RxPowerLowAlarm : -21.024dBm RxPowerLowWarning : -18.013dBm TxBiasHighAlarm : 450.0mA TxBiasHighWarning : 420.0mA TxBiasLowAlarm : 100.0mA TxBiasLowWarning : 110.0mA TxPowerHighAlarm : -5.0dBm TxPowerHighWarning: -6.0dBm TxPowerLowAlarm : -16.99dBm TxPowerLowWarning : -16.003dBm ModuleMonitorValues: Temperature: 52.848C Vcc: 3.331Volts ModuleThresholdValues: TempHighAlarm : 80.0C TempHighWarning: 75.0C TempLowAlarm : -5.0C TempLowWarning : 0.0C VccHighAlarm : 3.465Volts VccHighWarning : 3.4Volts VccLowAlarm : 3.1Volts VccLowWarning : 3.15VoltsNew command output (if the output of a command-line utility has changed)
For 400ZR optic:
show int trans eeprom Ethernet0 -d Ethernet0: SFP EEPROM detected Active Firmware: 3.3.36 Active application selected code assigned to host lane 1: 1 Active application selected code assigned to host lane 2: 1 Active application selected code assigned to host lane 3: 1 Active application selected code assigned to host lane 4: 1 Active application selected code assigned to host lane 5: 1 Active application selected code assigned to host lane 6: 1 Active application selected code assigned to host lane 7: 1 Active application selected code assigned to host lane 8: 1 Application Advertisement: 400GAUI-8 C2M (Annex 120E) - Host Assign (0x1) - 400ZR, DWDM, amplified - Media Assign (0x1) 100GAUI-2 C2M (Annex 135G) - Host Assign (0x55) - 400ZR, DWDM, amplified - Media Assign (0x1) CMIS Rev: 5.0 Connector: LC Encoding: N/A Extended Identifier: Power Class 8 (18.0W Max) Extended RateSelect Compliance: N/A Host Lane Count: 8 Identifier: QSFP-DD Double Density 8X Pluggable Transceiver Inactive Firmware: 3.3.36 Length Cable Assembly(m): 0.0 Media Interface Technology: C-band tunable laser Media Lane Count: 1 Module Hardware Rev: 0.0 Nominal Bit Rate(100Mbs): N/A Specification compliance: sm_media_interface Supported Max Laser Frequency: 196100 Supported Max TX Power: -8.5 Supported Min Laser Frequency: 191300 Supported Min TX Power: -14.0 Vendor Date Code(YYYY-MM-DD Lot): 2024-01-20 Vendor Name: INPHI CORP Vendor OUI: 00-21-b8 Vendor PN: IN-Q3JZ1-TC-M1 Vendor Rev: 01 Vendor SN: L2403D0925C is_replaceable: True type_abbrv_name: QSFP-DD vdm_supported: True ChannelMonitorValues: RX1Power: -8.735dBm RX2Power: -infdBm RX3Power: -infdBm RX4Power: -infdBm RX5Power: -infdBm RX6Power: -infdBm RX7Power: -infdBm RX8Power: -infdBm TX1Bias: 208.0mA TX1Power: -8.499dBm TX2Bias: 0.0mA TX2Power: -infdBm TX3Bias: 0.0mA TX3Power: -infdBm TX4Bias: 0.0mA TX4Power: -infdBm TX5Bias: 0.0mA TX5Power: -infdBm TX6Bias: 0.0mA TX6Power: -infdBm TX7Bias: 0.0mA TX7Power: -infdBm TX8Bias: 0.0mA TX8Power: -infdBm ChannelThresholdValues: RxPowerHighAlarm : 2.0dBm RxPowerHighWarning: 0.0dBm RxPowerLowAlarm : -21.024dBm RxPowerLowWarning : -18.013dBm TxBiasHighAlarm : 450.0mA TxBiasHighWarning : 420.0mA TxBiasLowAlarm : 100.0mA TxBiasLowWarning : 110.0mA TxPowerHighAlarm : -5.0dBm TxPowerHighWarning: -6.0dBm TxPowerLowAlarm : -16.99dBm TxPowerLowWarning : -16.003dBm ModuleMonitorValues: Tx Frequency: 193100GHz Requested Laser Frequency: 193100.0GHz Temperature: 52.848C Vcc: 3.331Volts ModuleThresholdValues: TempHighAlarm : 80.0C TempHighWarning: 75.0C TempLowAlarm : -5.0C TempLowWarning : 0.0C VccHighAlarm : 3.465Volts VccHighWarning : 3.4Volts VccLowAlarm : 3.1Volts VccLowWarning : 3.15VoltsTested on 400G QSFP+C:
admin@STR43-UT2-NH5010-01:/usr/local/bin$ show int trans eeprom Ethernet128 -d Ethernet128: SFP EEPROM detected Active Firmware: 3.4.0 Active application selected code assigned to host lane 1: 1 Active application selected code assigned to host lane 2: 1 Active application selected code assigned to host lane 3: 1 Active application selected code assigned to host lane 4: 1 Active application selected code assigned to host lane 5: N/A Active application selected code assigned to host lane 6: N/A Active application selected code assigned to host lane 7: N/A Active application selected code assigned to host lane 8: N/A Application Advertisement: 400GAUI-4-S C2M (Annex 120G) - Host Assign (0x1) - Active Cable assembly with BER < 2.6x10^-4 - Media Assign (0x1) 200GAUI-2-S C2M (Annex 120G) - Host Assign (0x5) - Active Cable assembly with BER < 2.6x10^-4 - Media Assign (0x5) 100GAUI-1-S C2M (Annex 120G) - Host Assign (0xf) - Active Cable assembly with BER < 2.6x10^-4 - Media Assign (0xf) CMIS Rev: 5.2 Connector: No separable connector Encoding: N/A Extended Identifier: Power Class 6 (4.5W Max) Extended RateSelect Compliance: N/A Host Lane Count: 4 Identifier: QSFP+ or later with CMIS Inactive Firmware: 3.0.0 Length Cable Assembly(m): 1.0 Media Interface Technology: 1310 nm DFB Media Lane Count: 4 Module Hardware Rev: 1.0 Nominal Bit Rate(100Mbs): N/A Specification compliance: active_cable_media_interface Vendor Date Code(YYYY-MM-DD Lot): 2025-11-03 Vendor Name: Eoptolink Vendor OUI: 70-ee-a3 Vendor PN: EQ138HGPCT01CSL1 Vendor Rev: 01 Vendor SN: URB3010001A is_replaceable: True type_abbrv_name: QSFP+C vdm_supported: False ChannelMonitorValues: RX1Power: 1.909dBm RX2Power: 1.137dBm RX3Power: 1.651dBm RX4Power: 1.596dBm RX5Power: -infdBm RX6Power: -infdBm RX7Power: -infdBm RX8Power: -infdBm TX1Bias: 130.032mA TX1Power: 0.714dBm TX2Bias: 129.968mA TX2Power: 1.119dBm TX3Bias: 130.032mA TX3Power: 1.125dBm TX4Bias: 129.968mA TX4Power: 0.97dBm TX5Bias: 0.0mA TX5Power: -infdBm TX6Bias: 0.0mA TX6Power: -infdBm TX7Bias: 0.0mA TX7Power: -infdBm TX8Bias: 0.0mA TX8Power: -infdBm ChannelThresholdValues: RxPowerHighAlarm : 6.5dBm RxPowerHighWarning: 5.5dBm RxPowerLowAlarm : -8.401dBm RxPowerLowWarning : -7.399dBm TxBiasHighAlarm : 400.0mA TxBiasHighWarning : 380.0mA TxBiasLowAlarm : 10.0mA TxBiasLowWarning : 15.0mA TxPowerHighAlarm : 6.0dBm TxPowerHighWarning: 5.0dBm TxPowerLowAlarm : -7.001dBm TxPowerLowWarning : -6.0dBm ModuleMonitorValues: Temperature: 38.598C Vcc: 3.41Volts ModuleThresholdValues: TempHighAlarm : 78.0C TempHighWarning: 73.0C TempLowAlarm : -8.0C TempLowWarning : -3.0C VccHighAlarm : 3.63Volts VccHighWarning : 3.465Volts VccLowAlarm : 2.97Volts VccLowWarning : 3.135VoltsThe output stayed the same for non-400ZR optic.
Command output on non-cmis optic: