Checker to check if the lag-ids are in sync with chassisdb. by arlakshm · Pull Request #4082 · sonic-net/sonic-utilities

arlakshm · 2025-10-07T00:28:16Z

What I did

This PR introduces a new monitoring script to check synchronization of LAG (Link Aggregation Group) IDs between the chassis database and ASIC databases on VOQ chassis line cards. The script is designed to be run by Monit and will alert via syslog when mismatches are detected.

How I did it

Key Changes
Added chassis_lag_id_checker script that retrieves and compares LAG IDs from chassis_db and asic_db, reporting mismatches per ASIC namespace
Comprehensive test suite with fixtures for mocking Redis dumps and ASIC/device configurations
Integration into setup.py for proper installation

How to verify it

test on voq chassis and UT

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

mssonicbld · 2025-10-07T00:28:24Z

/azp run

azure-pipelines · 2025-10-07T00:28:34Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-30T18:28:54Z

/azp run

azure-pipelines · 2025-11-30T18:29:03Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR introduces a new monitoring script to check synchronization of LAG (Link Aggregation Group) IDs between the chassis database and ASIC databases on VOQ chassis line cards. The script is designed to be run by Monit and will alert via syslog when mismatches are detected.

Key Changes

Added chassis_lag_id_checker script that retrieves and compares LAG IDs from chassis_db and asic_db, reporting mismatches per ASIC namespace
Comprehensive test suite with fixtures for mocking Redis dumps and ASIC/device configurations
Integration into setup.py for proper installation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File	Description
scripts/chassis_lag_id_checker	New monitoring script that checks LAG ID synchronization between chassis_db and asic_db on VOQ chassis line cards
tests/chassis_lag_id_checker_test.py	Test suite covering the main functions of the checker script with mock Redis data
setup.py	Adds the new chassis_lag_id_checker script to the installation scripts list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

scripts/chassis_lag_id_checker

tests/chassis_lag_id_checker_test.py

tests/chassis_db_consistency_checker_test.py

tests/chassis_lag_id_checker_test.py

scripts/chassis_lag_id_checker

mssonicbld · 2025-11-30T18:36:22Z

/azp run

azure-pipelines · 2025-11-30T18:36:33Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-30T18:36:44Z

/azp run

azure-pipelines · 2025-11-30T18:36:53Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-30T18:37:58Z

/azp run

azure-pipelines · 2025-11-30T18:38:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

mssonicbld · 2025-12-01T19:42:54Z

/azp run

azure-pipelines · 2025-12-01T19:43:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

mssonicbld · 2025-12-01T22:52:24Z

/azp run

azure-pipelines · 2025-12-01T22:52:34Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

mssonicbld · 2025-12-01T23:18:37Z

/azp run

azure-pipelines · 2025-12-01T23:18:47Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

mssonicbld · 2025-12-01T23:23:26Z

/azp run

azure-pipelines · 2025-12-01T23:23:36Z

Azure Pipelines successfully started running 1 pipeline(s).

scripts/chassis_lag_id_checker

scripts/chassis_db_consistency_checker.py

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

mssonicbld · 2025-12-04T19:24:12Z

/azp run

azure-pipelines · 2025-12-04T19:24:23Z

Azure Pipelines successfully started running 1 pipeline(s).

deepak-singhal0408

LGTM. thanks,

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

mssonicbld · 2025-12-04T19:38:34Z

/azp run

azure-pipelines · 2025-12-04T19:38:45Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-12-04T20:11:36Z

Cherry-pick PR to msft-202405:

What I did This PR introduces a new monitoring script to check synchronization of LAG (Link Aggregation Group) IDs between the chassis database and ASIC databases on VOQ chassis line cards. The script is designed to be run by Monit and will alert via syslog when mismatches are detected. port sonic-net/sonic-utilities#4082 to 202405 How I did it Key Changes Added chassis_lag_id_checker script that retrieves and compares LAG IDs from chassis_db and asic_db, reporting mismatches per ASIC namespace Comprehensive test suite with fixtures for mocking Redis dumps and ASIC/device configurations Integration into setup.py for proper installation How to verify it test on voq chassis and UT

…t#4082) What I did This PR introduces a new monitoring script to check synchronization of LAG (Link Aggregation Group) IDs between the chassis database and ASIC databases on VOQ chassis line cards. The script is designed to be run by Monit and will alert via syslog when mismatches are detected. How I did it Key Changes Added chassis_lag_id_checker script that retrieves and compares LAG IDs from chassis_db and asic_db, reporting mismatches per ASIC namespace Comprehensive test suite with fixtures for mocking Redis dumps and ASIC/device configurations Integration into setup.py for proper installation How to verify it test on voq chassis and UT Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm marked this pull request as ready for review November 30, 2025 18:30

Copilot AI review requested due to automatic review settings November 30, 2025 18:30

Copilot started reviewing on behalf of arlakshm November 30, 2025 18:31 View session

Copilot finished reviewing on behalf of arlakshm November 30, 2025 18:32

Copilot AI reviewed Nov 30, 2025

View reviewed changes

arlakshm and others added 7 commits December 1, 2025 19:41

add new lag id checker for voq chassis

1a9e561

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

update run command

fbd2b6a

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Add UT

c286548

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Update scripts/chassis_lag_id_checker

906e2cb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Update scripts/chassis_lag_id_checker

ebd7136

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Update scripts/chassis_lag_id_checker

499a954

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Add more UT

141e72e

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm force-pushed the dev/arlakshm/lag_id_check branch from 0aaa75e to 141e72e Compare December 1, 2025 19:42

Fix pre-commit changes and more UT

9e4671a

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

fix linter

d15eae2

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm requested a review from deepak-singhal0408 December 1, 2025 23:19

fix linter again

88b82d6

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

deepak-singhal0408 reviewed Dec 4, 2025

View reviewed changes

scripts/chassis_lag_id_checker Show resolved Hide resolved

deepak-singhal0408 reviewed Dec 4, 2025

View reviewed changes

scripts/chassis_db_consistency_checker.py Show resolved Hide resolved

address review comments

00b4ff0

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

deepak-singhal0408 previously approved these changes Dec 4, 2025

View reviewed changes

fix linter

a7787ab

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm dismissed deepak-singhal0408’s stale review via a7787ab December 4, 2025 19:38

deepak-singhal0408 approved these changes Dec 4, 2025

View reviewed changes

arlakshm added this to SONiC Chassis Dec 4, 2025

arlakshm added Request for msft-202405 Branch Approved for msft-202405 Branch Request for 202511 Branch labels Dec 4, 2025

mssonicbld added the Cherry Pick Conflict_msft-202405 label Dec 4, 2025

arlakshm merged commit 1f6613f into sonic-net:master Dec 4, 2025
8 checks passed

github-project-automation bot moved this to Done in SONiC Chassis Dec 4, 2025

mssonicbld added the Created PR to msft-202405 Branch label Dec 4, 2025

arlakshm mentioned this pull request Dec 4, 2025

[202405] Add chassis_db_consistency checker for voq chassis Azure/sonic-utilities.msft#260

Merged

Conversation

arlakshm commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

mssonicbld commented Oct 7, 2025

Uh oh!

azure-pipelines bot commented Oct 7, 2025

Uh oh!

mssonicbld commented Nov 30, 2025

Uh oh!

azure-pipelines bot commented Nov 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Nov 30, 2025

Uh oh!

azure-pipelines bot commented Nov 30, 2025

Uh oh!

mssonicbld commented Nov 30, 2025

Uh oh!

azure-pipelines bot commented Nov 30, 2025

Uh oh!

mssonicbld commented Nov 30, 2025

Uh oh!

azure-pipelines bot commented Nov 30, 2025

Uh oh!

mssonicbld commented Dec 1, 2025

Uh oh!

azure-pipelines bot commented Dec 1, 2025

Uh oh!

mssonicbld commented Dec 1, 2025

Uh oh!

azure-pipelines bot commented Dec 1, 2025

Uh oh!

mssonicbld commented Dec 1, 2025

Uh oh!

azure-pipelines bot commented Dec 1, 2025

Uh oh!

mssonicbld commented Dec 1, 2025

Uh oh!

azure-pipelines bot commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Dec 4, 2025

Uh oh!

azure-pipelines bot commented Dec 4, 2025

Uh oh!

deepak-singhal0408 left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 4, 2025

Uh oh!

azure-pipelines bot commented Dec 4, 2025

Uh oh!

Uh oh!

mssonicbld commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

arlakshm commented Oct 7, 2025 •

edited

Loading