[action] [PR:3988] Exclude Smart Switch from modular chassis operations/checks#4008
Merged
mssonicbld merged 1 commit intosonic-net:202505from Aug 1, 2025
Merged
Conversation
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### Why I did it
When running the `test_fwutil_update_current` test in https://github.com/sonic-net/sonic-mgmt/blob/master/tests/platform_tests/fwutil/test_fwutil.py we encounter the following issue when we run the command
```
admin@sonic:$ sudo fwutil update chassis component ONIE fw -y
Error: Failed to parse "platform_components.json": invalid platform schema: "module" key hasn't been found. Aborting...
Aborted!
```
This is because platform_components.json for smartswitch doesn't have module key in it and this should be ignored for smartswitch.
#### What I did
Avoid any modular chassis operations on smart-switch.
#### How I did it
Added a check to verify the device is not a smart switch before treating it as a modular chassis.
Collaborator
Author
|
Original PR: #3988 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kktheballer
pushed a commit
to kktheballer/sonic-utilities
that referenced
this pull request
Jan 14, 2026
```<br>* 1c262ab - (HEAD -> 202506) Merge branch '202505' of https://github.com/sonic-net/sonic-utilities into 202506 (2025-08-02) [Sonic Automation] * 5eac9e3 - (origin/202505) [db_migrator] Fix parse_xml fails when minigraph has SonicQosProfile (sonic-net#4009) (2025-08-01) [mssonicbld] * a3989b4 - Exclude Smart Switch from modular chassis operations/checks (sonic-net#4008) (2025-08-01) [mssonicbld]<br>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When running the
test_fwutil_update_currenttest in https://github.com/sonic-net/sonic-mgmt/blob/master/tests/platform_tests/fwutil/test_fwutil.py we encounter the following issue when we run the commandThis is because platform_components.json for smartswitch doesn't have module key in it and this should be ignored for smartswitch.
What I did
Avoid any modular chassis operations on smart-switch.
How I did it
Added a check to verify the device is not a smart switch before treating it as a modular chassis.