[sfputil debug] Fix issue: do not check output status when CMIS version is lower than 5.0#3938
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8017744 to
f2e2f6c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
f2e2f6c to
3d0bbd4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3d0bbd4 to
71185ef
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run sonic-utilities |
|
/AzurePipelines run sonic-utilities |
|
No pipelines are associated with this pull request. |
|
/azp run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
71185ef to
5065941
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5065941 to
05f480c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Junchao-Mellanox draft? |
|
Hi @prgeor , @mihirpat1 , could you please help review it? thanks! |
prgeor
left a comment
There was a problem hiding this comment.
@Junchao-Mellanox am I reading the wrong spec?

prgeor
left a comment
There was a problem hiding this comment.
seems we don't need this change.
|
Hi @prgeor , the PR is needed, we cannot check the tx/rx output status according to CMIS 4.2 spec: |
…ion is lower than 5.0
05f480c to
e1dd9e1
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to msft-202412: Azure/sonic-utilities.msft#212 |
|
For the 202505 cherry-pick conflict, need take #3911 first, then there will be no conflict. I have added label 202505 to PR #3911. @prgeor @mihirpat1 for awareness. |
|
Hi @prgeor @mihirpat1 , please suggest whether those PR should go to 202505 branch: |
|
Hi @Junchao-Mellanox , I've synced up with @prgeor , this PR is not suggested to be included 202505 branch, |
…ion is lower than 5.0 (sonic-net#3938)


What I did
OutputStatusTx and OutputStatusRx are only supported since CMIS 5.0.
sfputil debug tx-outputandsfputil debug rx-outputshould check them only if CMIS rev is higher or equal to 5.0.How I did it
get_tx_disableandget_rx_disableto check if the corresponding bits have been set bysfputil debugcommandHow to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)