show command for icmp echo offload sessions#3889
Merged
qiluo-msft merged 5 commits intosonic-net:masterfrom May 27, 2025
Merged
show command for icmp echo offload sessions#3889qiluo-msft merged 5 commits intosonic-net:masterfrom
qiluo-msft merged 5 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@manamand2020 please address the conflicts. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
previously approved these changes
May 25, 2025
Contributor
|
Hi @qiluo-msft - please help merge. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new show command to display ICMP echo offload sessions. Key changes include:
- Adding new ICMP session entries in state database mock files.
- Introducing a new icmp command and module in the show utility.
- Adding unit tests to validate the new command functionality.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/mock_tables/state_db.json | Added new ICMP_ECHO_SESSION_TABLE entries for testing. |
| tests/mock_tables/asic1/state_db.json | Added ICMP_ECHO_SESSION_TABLE entries to asic1 state db mock. |
| tests/mock_tables/asic0/state_db.json | Added ICMP_ECHO_SESSION_TABLE entries to asic0 state db mock. |
| tests/icmp_test.py | Added unit tests for displaying ICMP echo sessions and summary. |
| show/main.py | Registered the new icmp command with the CLI. |
| show/icmp.py | Implements the logic for showing ICMP echo session details. |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
approved these changes
May 26, 2025
qiluo-msft
approved these changes
May 27, 2025
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
What I did Added show command to display icmp echo offload sessions How I did it added show utility icmp.py How to verify it added pytests to verify
Contributor
|
Hi @qiluo-msft , it looks like a slight new feature, could you please comment if it is must-have for 202505 branch? |
Contributor
|
Hi @yejianquan - the feature is already merged into 202505. So if we can have this show cmd merged too into 202505 that will be great. |
Contributor
|
Hi @manamand2020 , can you fix the conflict and raise PR to 202505 branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added show command to display icmp echo offload sessions
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)