Addition of prober_type in config and show commands for muxcable by harjotsinghpawra · Pull Request #3884 · sonic-net/sonic-utilities

harjotsinghpawra · 2025-05-15T21:58:04Z

New prober_type harware is being added to linkmgrd. This is config knob addition for the specific field in mUX_CABLE
show command show muxcable config edited to add prober_type field

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

linux-foundation-easycla · 2025-05-15T21:58:08Z

The committers listed above are authorized under a signed CLA.

✅ login: harjotsinghpawra (8d61e01, 07a09fb, 5a108b7, ff0f27e, fd9db0b)

mssonicbld · 2025-05-15T21:58:12Z

/azp run

azure-pipelines · 2025-05-15T21:58:22Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-17T07:09:07Z

/azp run

azure-pipelines · 2025-05-17T07:09:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-17T07:48:21Z

/azp run

azure-pipelines · 2025-05-17T07:48:30Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-17T07:56:41Z

/azp run

azure-pipelines · 2025-05-17T07:56:51Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-18T05:43:04Z

/azp run

azure-pipelines · 2025-05-18T05:43:14Z

Azure Pipelines successfully started running 1 pipeline(s).

harjotsinghpawra · 2025-05-18T06:05:04Z

/azp run

azure-pipelines · 2025-05-18T06:05:10Z

Commenter does not have sufficient privileges for PR 3884 in repo sonic-net/sonic-utilities

harjotsinghpawra · 2025-05-19T06:22:16Z

Hi can someone help azure runs are cancelled because of no apparent reason , no reviewer is assigned so not sure whom to reach out

Copilot

Pull Request Overview

This PR adds a new "prober_type" field to muxcable commands so that both configuration and output (table and JSON) include the prober type setting.

Added "prober_type" to muxcable configuration and show commands
Updated tests and mock configuration to validate the new field

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/muxcable_test.py	Updated test outputs and added tests for the prober_type command
tests/mock_tables/config_db.json	Included prober_type entries for specific ports
show/muxcable.py	Updated table and JSON dump to display the prober_type field
config/muxcable.py	Added a new command and helper to update prober_type in configdb

Comments suppressed due to low confidence (1)

config/muxcable.py:439

[nitpick] For consistency and clarity with other parts of the code, consider renaming the variable 'asic_index' to 'asic_id' within this logical block.

if port is not None and port != "all":

Copilot · 2025-05-21T04:58:54Z

show/muxcable.py

                    click.echo(tabulate(print_peer_tor, headers=headers))
                    if is_dualtor_active_active[0]:
-                        headers = ['port', 'state', 'ipv4', 'ipv6', 'cable_type', 'soc_ipv4', 'soc_ipv6']
+                        headers = ['port', 'state', 'ipv4', 'ipv6', 'cable_type', 'soc_ipv4', 'soc_ipv6', 'prober_type']


Consider refactoring the header definitions into a shared constant to reduce duplication across similar code blocks.

zjswhhh · 2025-05-21T04:59:48Z

Hi can someone help azure runs are cancelled because of no apparent reason , no reviewer is assigned so not sure whom to reach out

@harjotsinghpawra - I tried triggering the pipeline, but it was cancelled for same reason. Can you do a rebase and push for a rerun?

zjswhhh · 2025-05-22T05:14:04Z

config/muxcable.py

        ctx.fail("Invalid ConfigDB. Error: {}".format(e))

+
+def update_configdb_prober_type(config_db, port, val):


Do we need to carry over prober type in update_configdb_pck_loss_data as well?

yes , we need to carry soc_ipv4 field also over to update_configdb_pck_loss_data

Fixed , updated the diff

mssonicbld · 2025-05-22T17:50:27Z

/azp run

azure-pipelines · 2025-05-22T17:50:38Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-22T17:53:55Z

/azp run

azure-pipelines · 2025-05-22T17:54:06Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-22T17:55:13Z

/azp run

azure-pipelines · 2025-05-22T17:55:23Z

Azure Pipelines successfully started running 1 pipeline(s).

zjswhhh

lgtm

zjswhhh · 2025-05-22T19:11:08Z

Hi @qiluo-msft - please help merge.

…ic-net#3884) New prober_type harware is being added to linkmgrd. This is config knob addition for the specific field in mUX_CABLE show command show muxcable config edited to add prober_type field

…ble (#3884)" This reverts commit b106a82.

…ble (#3884)" (#3979) This reverts commit b106a82. This PR caused issue: #3978 Need to revert it to unblock submodule advance for sonic-utilities.

…4013) Orignal PR was reverted because of pre-test failure as part of following issue #3978 orignal PR #3884 What I did How I did it Fixed show mux config to one format no matter if soc_ipv4 is given or not How to verify it Ran the test_pretest as part of sonic_mgmt Previous command output (if the output of a command-line utility has changed) port state ipv4 ipv6 cable_type soc_ipv4 soc_ipv6 Ethernet8 auto 192.168.0.2/32 fc02:1000::2/128 active-active 192.168.0.3/32 Ethernet16 auto 192.168.0.4/32 fc02:1000::4/128 active-active 192.168.0.5/32 New command output (if the output of a command-line utility has changed) port state ipv4 ipv6 cable_type soc_ipv4 soc_ipv6 prober_type Ethernet8 auto 192.168.0.2/32 fc02:1000::2/128 active-active 192.168.0.3/32 software Ethernet16 auto 192.168.0.4/32 fc02:1000::4/128 active-active 192.168.0.5/32 software

…ble (sonic-net#3884)" (sonic-net#3979) This reverts commit b106a82. This PR caused issue: sonic-net#3978 Need to revert it to unblock submodule advance for sonic-utilities.

…onic-net#4013) Orignal PR was reverted because of pre-test failure as part of following issue sonic-net#3978 orignal PR sonic-net#3884 What I did How I did it Fixed show mux config to one format no matter if soc_ipv4 is given or not How to verify it Ran the test_pretest as part of sonic_mgmt Previous command output (if the output of a command-line utility has changed) port state ipv4 ipv6 cable_type soc_ipv4 soc_ipv6 Ethernet8 auto 192.168.0.2/32 fc02:1000::2/128 active-active 192.168.0.3/32 Ethernet16 auto 192.168.0.4/32 fc02:1000::4/128 active-active 192.168.0.5/32 New command output (if the output of a command-line utility has changed) port state ipv4 ipv6 cable_type soc_ipv4 soc_ipv6 prober_type Ethernet8 auto 192.168.0.2/32 fc02:1000::2/128 active-active 192.168.0.3/32 software Ethernet16 auto 192.168.0.4/32 fc02:1000::4/128 active-active 192.168.0.5/32 software

Addition of prober_type in config and show commands for muxcable

07a09fb

harjotsinghpawra force-pushed the harjosin_icmp branch from f5cbd88 to 07a09fb Compare May 17, 2025 07:08

pre-commit fix

5a108b7

pre-commit indent fix

fd9db0b

pre-commit over-indent fix

ff0f27e

zjswhhh requested review from Copilot and zjswhhh May 21, 2025 04:58

Copilot AI reviewed May 21, 2025

View reviewed changes

zjswhhh reviewed May 22, 2025

View reviewed changes

harjotsinghpawra force-pushed the harjosin_icmp branch from e101b88 to 9522356 Compare May 22, 2025 17:53

update_configdb_pck_loss_data prober_type field addition

8d61e01

harjotsinghpawra force-pushed the harjosin_icmp branch from 9522356 to 8d61e01 Compare May 22, 2025 17:55

zjswhhh approved these changes May 22, 2025

View reviewed changes

qiluo-msft merged commit b106a82 into sonic-net:master May 22, 2025
7 checks passed

manamand2020 mentioned this pull request May 31, 2025

HLD for ICMP Hardware Offload sonic-net/SONiC#1952

Merged

wangxin mentioned this pull request Jul 17, 2025

Title not aligned with correct column in "show mux config" output #3978

Open

wangxin added a commit that referenced this pull request Jul 17, 2025

Revert "Addition of prober_type in config and show commands for muxca…

84862c8

…ble (#3884)" This reverts commit b106a82.

wangxin mentioned this pull request Jul 17, 2025

Revert "Addition of prober_type in config and show commands for muxcable" #3979

Merged

harjotsinghpawra mentioned this pull request Aug 4, 2025

Mux cable show config command Added prober_type and fixed one format #4013

Merged

		ctx.fail("Invalid ConfigDB. Error: {}".format(e))


		def update_configdb_prober_type(config_db, port, val):

Conversation

harjotsinghpawra commented May 15, 2025

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

linux-foundation-easycla bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented May 15, 2025

Uh oh!

azure-pipelines bot commented May 15, 2025

Uh oh!

mssonicbld commented May 17, 2025

Uh oh!

azure-pipelines bot commented May 17, 2025

Uh oh!

mssonicbld commented May 17, 2025

Uh oh!

azure-pipelines bot commented May 17, 2025

Uh oh!

mssonicbld commented May 17, 2025

Uh oh!

azure-pipelines bot commented May 17, 2025

Uh oh!

mssonicbld commented May 18, 2025

Uh oh!

azure-pipelines bot commented May 18, 2025

Uh oh!

harjotsinghpawra commented May 18, 2025

Uh oh!

azure-pipelines bot commented May 18, 2025

Uh oh!

harjotsinghpawra commented May 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 21, 2025

Choose a reason for hiding this comment

Uh oh!

zjswhhh commented May 21, 2025

Uh oh!

zjswhhh May 22, 2025

Choose a reason for hiding this comment

Uh oh!

harjotsinghpawra May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harjotsinghpawra May 22, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented May 22, 2025

Uh oh!

azure-pipelines bot commented May 22, 2025

Uh oh!

mssonicbld commented May 22, 2025

Uh oh!

azure-pipelines bot commented May 22, 2025

Uh oh!

mssonicbld commented May 22, 2025

Uh oh!

azure-pipelines bot commented May 22, 2025

Uh oh!

zjswhhh left a comment

Choose a reason for hiding this comment

Uh oh!

zjswhhh commented May 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

linux-foundation-easycla bot commented May 15, 2025 •

edited

Loading

harjotsinghpawra May 22, 2025 •

edited

Loading