[muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table by mihirpat1 · Pull Request #3857 · sonic-net/sonic-utilities

mihirpat1 · 2025-04-16T04:41:08Z

What I did

xcvrd will now move the status field from the TRANSCEIVER_STATUS table to the TRANSCEIVER_STATUS_SW table. This is being done via the below PRs

Update CMIS diagnostics monitoring HLD with TRANSCEIVER_STATUS_SW table by mihirpat1 · Pull Request #1964 · sonic-net/SONiC
[xcvrd] Re-organize transceiver DOM and STATUS tables by mihirpat1 · Pull Request #604 · sonic-net/sonic-platform-daemons

Therefore, the corresponding CLIs that rely on the TRANSCEIVER_STATUS table for retrieving transceiver presence need to be changed.

However, a more robust method to retrieve transceiver presence is by checking if the TRANSCEIVER_INFO table is present. Thus, the relevant code change will be made to address this.

How I did it

The CLI handler now looks at the TRANSCEIVER_INFO table to find transceiver presence

How to verify it

No change in output when command is executed after putting the change manaully

admin@sonic:~$ show mux grpc mux
Port        Direction    Presence    PeerDirection    ConnectivityState
----------  -----------  ----------  ---------------  -------------------
Ethernet4   unknown      True        unknown          unknown
Ethernet8   unknown      True        unknown          unknown
Ethernet12  unknown      True        unknown          unknown
Ethernet16  unknown      True        unknown          unknown
Ethernet20  unknown      True        unknown          unknown
Ethernet24  unknown      True        unknown          unknown
Ethernet28  unknown      True        unknown          unknown

For the case where TRANSCEIVER_INFO table is missing by manually deleteing it for example on Port Ethernet4

admin@sonic:~$ redis-cli -n 6 DEL "TRANSCEIVER_INFO|Ethernet4"
(integer) 1
admin@sonic:~$ show mux grpc mux
Port        Direction    Presence    PeerDirection    ConnectivityState
----------  -----------  ----------  ---------------  -------------------
Ethernet4   standby      False       standby          READY
Ethernet8   standby      True        standby          READY

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

MSFT ADO - 32337615

…om TRANSCEIVER_INFO table Signed-off-by: Mihir Patel <[email protected]>

mssonicbld · 2025-04-16T04:41:16Z

/azp run

Copilot

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)

tests/mock_tables/state_db.json: Language not supported

azure-pipelines · 2025-04-16T04:41:26Z

Azure Pipelines successfully started running 1 pipeline(s).

vdahiya12 · 2025-04-17T23:57:01Z

show/muxcable.py

        state_db[asic_index].STATE_DB, 'MUX_CABLE_INFO|{}'.format(port))
    trans_info_full_dict[asic_index] = state_db[asic_index].get_all(
-        state_db[asic_index].STATE_DB, 'TRANSCEIVER_STATUS|{}'.format(port))
+        state_db[asic_index].STATE_DB, 'TRANSCEIVER_INFO|{}'.format(port)) or {}


what is the or condition here ?

@vdahiya12 The or condition is just to ensure that an empty dictionary is returned rather None to avoid a crash.

vdahiya12 · 2025-04-17T23:58:45Z

show/muxcable.py

@@ -2187,9 +2187,8 @@ def get_grpc_cached_version_mux_direction_per_port(db, port):

    trans_dir = {}
    trans_dir = trans_info_full_dict[asic_index]


shall we add a get call here, that would be easier to read the code below

trans_dir = trans_info_full_dict.get(asic_index, None)

@vdahiya12 Makes sense. Added it now.

vdahiya12 · 2025-04-18T00:00:42Z

Do we have a negative test case, to give presence as False if table not populated?

please check.

mssonicbld · 2025-04-18T00:20:04Z

/azp run

azure-pipelines · 2025-04-18T00:20:14Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR adds gRPC CLI support for transceiver presence retrieval by switching from the TRANSCEIVER_STATUS table to checking the TRANSCEIVER_INFO table.

The CLI handler now retrieves transceiver data from TRANSCEIVER_INFO.
Test expectations have been updated to reflect the revised presence evaluation.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/muxcable_test.py	Expected output updated: presence for Ethernet0 changed from False to True.
show/muxcable.py	Modified get_grpc_cached_version_mux_direction_per_port to use TRANSCEIVER_INFO.

Files not reviewed (1)

tests/mock_tables/state_db.json: Language not supported

Copilot · 2025-04-18T00:23:25Z

show/muxcable.py

+    presence = "True" if trans_dir else "False"



Ensure that the logic for determining transceiver presence correctly handles cases where the TRANSCEIVER_INFO table exists but returns an empty dictionary. If an empty dictionary should imply absence, the current condition is valid; otherwise, please adjust the condition accordingly.

Suggested change

presence = "True" if trans_dir else "False"

if trans_dir is not None: # Table exists

presence = "True" # Treat empty dictionary as presence

else:

presence = "False" # Table does not exist

mssonicbld · 2025-04-28T02:14:11Z

Cherry-pick PR to msft-202412: Azure/sonic-utilities.msft#171

…om TRANSCEIVER_INFO table (sonic-net#3857) * [muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table Signed-off-by: Mihir Patel <[email protected]> * Using .get method to initialize trans_dir --------- Signed-off-by: Mihir Patel <[email protected]>

…ted changes (sonic-net#170) * [muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table (sonic-net#3857) * [muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table Signed-off-by: Mihir Patel <[email protected]> * Using .get method to initialize trans_dir --------- Signed-off-by: Mihir Patel <[email protected]> * Transceiver CLI changes to support DOM and STATUS table related changes Signed-off-by: Mihir Patel <[email protected]> --------- Signed-off-by: Mihir Patel <[email protected]>

…om TRANSCEIVER_INFO table (sonic-net#3857) * [muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table Signed-off-by: Mihir Patel <[email protected]> * Using .get method to initialize trans_dir --------- Signed-off-by: Mihir Patel <[email protected]>

[muxcable] Add grpc CLI support for transceiver presence retrieval fr…

d0b5bda

…om TRANSCEIVER_INFO table Signed-off-by: Mihir Patel <[email protected]>

mihirpat1 requested a review from Copilot April 16, 2025 04:41

Copilot AI reviewed Apr 16, 2025

View reviewed changes

mihirpat1 requested review from prgeor and vdahiya12 April 16, 2025 04:42

mihirpat1 added the Request for msft-202412 Branch label Apr 16, 2025

mihirpat1 changed the title ~~[muxcable] Add grpc CLI support for transceiver presence retrieval fr…~~ [muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table Apr 16, 2025

prgeor previously approved these changes Apr 16, 2025

View reviewed changes

vdahiya12 reviewed Apr 17, 2025

View reviewed changes

Using .get method to initialize trans_dir

683120a

mihirpat1 dismissed prgeor’s stale review via 683120a April 18, 2025 00:19

mihirpat1 requested a review from Copilot April 18, 2025 00:23

Copilot AI reviewed Apr 18, 2025

View reviewed changes

vdahiya12 approved these changes Apr 18, 2025

View reviewed changes

prgeor merged commit 4ce4c2d into sonic-net:master Apr 22, 2025
7 checks passed

r12f added the Approved for msft-202412 Branch label Apr 28, 2025

mssonicbld mentioned this pull request Apr 28, 2025

[action] [PR:3857] [muxcable] Add grpc CLI support for transceiver presence retrieval from TRANSCEIVER_INFO table Azure/sonic-utilities.msft#171

Merged

mssonicbld added the Created PR to msft-202412 Branch label Apr 28, 2025

mssonicbld added Included in msft-202412 Branch and removed Created PR to msft-202412 Branch labels Apr 28, 2025

mihirpat1 mentioned this pull request Jul 8, 2025

[202411] DOM enhancement changes for transceiver CLIs #3957

Closed

		@@ -2187,9 +2187,8 @@ def get_grpc_cached_version_mux_direction_per_port(db, port):

		trans_dir = {}
		trans_dir = trans_info_full_dict[asic_index]

-    presence = "True" if trans_dir else "False"
+    if trans_dir is not None:  # Table exists
+        presence = "True"  # Treat empty dictionary as presence
+    else:
+        presence = "False"  # Table does not exist

Conversation

mihirpat1 commented Apr 16, 2025 • edited by vdahiya12 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

mssonicbld commented Apr 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Apr 16, 2025

Uh oh!

vdahiya12 Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

mihirpat1 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

vdahiya12 Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

mihirpat1 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

vdahiya12 commented Apr 18, 2025

Uh oh!

mssonicbld commented Apr 18, 2025

Uh oh!

azure-pipelines bot commented Apr 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mihirpat1 commented Apr 16, 2025 •

edited by vdahiya12

Loading