Switchport mode update for 'show interfaces status' by cshivashgit · Pull Request #3788 · sonic-net/sonic-utilities

cshivashgit · 2025-02-27T10:15:31Z

What I did

Fixed "show interfaces status" output for interfaces with switchport mode configuration.

How I did it

Configured "switchport mode" is fetched from DB for all front panel ports and PortChannel interfaces.
"Vlan" column in "show interface status" is displayed based on below considerations:

If interface is part of PortChannel - display PortChannel interface name [present behavior]
If "switchport mode" is configured on interface [Ethernet/PortChannel] - display configured mode [new behavior]
If "switchport mode" is NOT configured on interface but part of a VLAN [Ethernet/PortChannel] - display as "trunk" [present behavior]
If "switchport mode" is NOT configured on interface and NOT part of a VLAN [Ethernet/PortChannel] - display as "routed" [present behavior]

How to verify it

Configure "switchport mode" for an interface/portchannel and verify the output in below show commands

show interfaces switchport status
show interfaces status

Previous command output (if the output of a command-line utility has changed)

Previously it was always displaying as trunk even if interface is configured as access

root@sonic:~# config switchport mode access Ethernet0
Ethernet0 switched to access mode

root@sonic:~# show interfaces switchport status | grep Ethernet0
Ethernet0    access

root@sonic:~#
root@sonic:~# show interfaces status | grep Ethernet0
  Ethernet0  2304,2305,2306,2307     100G   9100    N/A     etp0   trunk      up       up  QSFP28 or later         N/A

New command output (if the output of a command-line utility has changed)

root@sonic:~# config switchport mode access Ethernet0
Ethernet0 switched to access mode

root@sonic:~# show interfaces switchport status | grep Ethernet0
Ethernet0    access

root@sonic:~#
root@sonic:~# show interfaces status | grep Ethernet0
  Ethernet0  2304,2305,2306,2307     100G   9100    N/A     etp0   access      up       up  QSFP28 or later         N/A

closes #3787

mssonicbld · 2025-02-27T10:15:33Z

/azp run

linux-foundation-easycla · 2025-02-27T10:15:34Z

The committers listed above are authorized under a signed CLA.

✅ login: cshivashgit / name: Shivashankar C R (4344831, 8644b31)
✅ login: qiluo-msft / name: Qi Luo (610cb38, 2e81b49)

azure-pipelines · 2025-02-27T10:15:43Z

Azure Pipelines successfully started running 1 pipeline(s).

cshivashgit · 2025-02-28T03:57:57Z

@wen587 @xwjiang-ms please review

scripts/intfutil

wen587 · 2025-03-11T00:44:35Z

Could we add some ut for the new support?

mssonicbld · 2025-06-06T06:58:33Z

/azp run

azure-pipelines · 2025-06-06T06:58:44Z

Azure Pipelines successfully started running 1 pipeline(s).

RCA: According to present design port was conisdered as "trunk" if its part of a VLAN, there was no handling to fetch the acutal mode from Redis DB regarding the configured switchport mode. Solution: Configured "switchport mode" is fetched from DB for all front panel ports and PortChannel interfaces. "Vlan" column in "show interface status" is displayed based on below considerations: 1. If interface is part of PortChannel - display PortChannel interface name [present behavior] 2. If "switchport mode" is configured on interface [Ethernet/PortChannel] - display configured mode [new behavior] 3. If "switchport mode" is NOT configured on interface but part of a VLAN [Ethernet/PortChannel] - display as "trunk" [present behavior]

mssonicbld · 2025-06-06T07:44:09Z

/azp run

azure-pipelines · 2025-06-06T07:44:20Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-06T08:18:53Z

/azp run

azure-pipelines · 2025-06-06T08:19:03Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-06T08:35:11Z

/azp run

azure-pipelines · 2025-06-06T08:35:21Z

Azure Pipelines successfully started running 1 pipeline(s).

cshivashgit · 2025-06-06T09:11:20Z

Could we add some ut for the new support?

@wen587 : UT cases are added, please review.

wsycqyz

lğtm

vrajeshe · 2025-07-01T04:23:47Z

@wsycqyz
sonic-net/sonic-mgmt#17442
this is the tests for the same Pull req

vrajeshe · 2025-07-10T16:08:44Z

Hi @prgeor can you please check and merge this.

Thanks

vrajeshe · 2025-07-17T13:07:23Z

Sonic-Mgmt testcases for this PR
sonic-net/sonic-mgmt#17442

vrajeshe · 2025-07-18T08:54:13Z

Hi @prsunny Can you kindly help in merging this.

prsunny · 2025-07-18T18:44:03Z

@vrajeshe , can you update one more line in description

If "switchport mode" is NOT configured on interface and NOT part of a VLAN [Ethernet/PortChannel] - display as "routed"?

Basically want to ensure we don't change the existing behavior if switchport is not configured to 'access'.

@FengPan-Frank to review/approve

cshivashgit · 2025-07-20T07:23:13Z

@vrajeshe , can you update one more line in description

If "switchport mode" is NOT configured on interface and NOT part of a VLAN [Ethernet/PortChannel] - display as "routed"?

Basically want to ensure we don't change the existing behavior if switchport is not configured to 'access'.

@FengPan-Frank to review/approve

@prsunny Updated the description. Yes that is the present behaviour, we have not changed that.

FengPan-Frank

LGTM

prsunny · 2025-07-22T04:25:41Z

@qiluo-msft to merge

Copilot

Pull Request Overview

This PR fixes the "show interfaces status" command to properly display switchport modes in the "Vlan" column. Previously, interfaces configured with "switchport mode access" would incorrectly show as "trunk" in the status output.

Key changes:

Refactored interface vlan/mode determination logic to prioritize configured switchport modes
Added comprehensive test coverage for switchport mode verification
Updated the display logic to show configured switchport modes instead of inferring from VLAN membership

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
scripts/intfutil	Refactored vlan determination logic to use switchport mode configuration and updated function signatures
tests/vlan_test.py	Added test helper function and switchport mode verification to existing tests

scripts/intfutil

Copilot · 2025-07-22T22:16:29Z

tests/vlan_test.py

    def setup_class(cls):
-        os.environ['UTILITIES_UNIT_TESTING'] = "1"
+        os.environ["PATH"] += os.pathsep + scripts_path
+        os.environ['UTILITIES_UNIT_TESTING'] = "2"


The environment variable value changed from "1" to "2" without explanation. This magic number should be documented or use a descriptive constant to clarify why this change was made.

Suggested change

os.environ['UTILITIES_UNIT_TESTING'] = "2"

os.environ['UTILITIES_UNIT_TESTING'] = UNIT_TESTING_MODE_ENABLED

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mssonicbld · 2025-07-22T22:18:01Z

/azp run

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2025-07-22T22:18:07Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-07-22T22:18:10Z

/azp run

azure-pipelines · 2025-07-22T22:18:20Z

Azure Pipelines successfully started running 1 pipeline(s).

cshivashgit · 2025-07-24T04:19:42Z

@qiluo-msft : Can you please help me in merging this PR to 202505 branch as well?
I was not able to add the label Request for 202505 Branch

CC: @prsunny

qiluo-msft · 2025-07-24T20:42:08Z

@yejianquan please help check 202505.

Aravind-Subbaroyan · 2025-08-13T16:57:05Z

@yejianquan - Could you please help to cherry-pick for 202505?

mssonicbld · 2025-08-19T23:17:33Z

Cherry-pick PR to 202505: #4035

What I did Fixed "show interfaces status" output for interfaces with switchport mode configuration. How I did it Configured "switchport mode" is fetched from DB for all front panel ports and PortChannel interfaces. "Vlan" column in "show interface status" is displayed based on below considerations: If interface is part of PortChannel - display PortChannel interface name [present behavior] If "switchport mode" is configured on interface [Ethernet/PortChannel] - display configured mode [new behavior] If "switchport mode" is NOT configured on interface but part of a VLAN [Ethernet/PortChannel] - display as "trunk" [present behavior] If "switchport mode" is NOT configured on interface and NOT part of a VLAN [Ethernet/PortChannel] - display as "routed" [present behavior] How to verify it Configure "switchport mode" for an interface/portchannel and verify the output in below show commands show interfaces switchport status show interfaces status Previous command output (if the output of a command-line utility has changed) Previously it was always displaying as trunk even if interface is configured as access root@sonic:~# config switchport mode access Ethernet0 Ethernet0 switched to access mode root@sonic:~# show interfaces switchport status | grep Ethernet0 Ethernet0 access root@sonic:~# root@sonic:~# show interfaces status | grep Ethernet0 Ethernet0 2304,2305,2306,2307 100G 9100 N/A etp0 trunk up up QSFP28 or later N/A New command output (if the output of a command-line utility has changed) root@sonic:~# config switchport mode access Ethernet0 Ethernet0 switched to access mode root@sonic:~# show interfaces switchport status | grep Ethernet0 Ethernet0 access root@sonic:~# root@sonic:~# show interfaces status | grep Ethernet0 Ethernet0 2304,2305,2306,2307 100G 9100 N/A etp0 access up up QSFP28 or later N/A closes sonic-net#3787

FengPan-Frank reviewed Mar 1, 2025

View reviewed changes

scripts/intfutil Show resolved Hide resolved

FengPan-Frank previously approved these changes Mar 10, 2025

View reviewed changes

cshivashgit mentioned this pull request Mar 11, 2025

[VLAN][SW_MODE]: Switchport mode tests sonic-net/sonic-mgmt#17442

Open

11 tasks

cshivashgit dismissed FengPan-Frank’s stale review via 5f3096f June 6, 2025 07:44

cshivashgit force-pushed the show_interfaces_fix branch from 2e980db to 5f3096f Compare June 6, 2025 07:44

cshivashgit force-pushed the show_interfaces_fix branch from 5f3096f to 76d9279 Compare June 6, 2025 08:18

Adding UT cases

4344831

cshivashgit force-pushed the show_interfaces_fix branch from 76d9279 to 4344831 Compare June 6, 2025 08:35

wsycqyz previously approved these changes Jun 24, 2025

View reviewed changes

FengPan-Frank previously approved these changes Jul 21, 2025

View reviewed changes

prsunny previously approved these changes Jul 21, 2025

View reviewed changes

qiluo-msft requested a review from Copilot July 22, 2025 22:15

Copilot AI reviewed Jul 22, 2025

View reviewed changes

Update scripts/intfutil

2e81b49

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

qiluo-msft dismissed stale reviews from prsunny, FengPan-Frank, and wsycqyz via 2e81b49 July 22, 2025 22:17

Update scripts/intfutil

610cb38

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

qiluo-msft enabled auto-merge (squash) July 22, 2025 22:19

prsunny approved these changes Jul 22, 2025

View reviewed changes

qiluo-msft merged commit e18640e into sonic-net:master Jul 22, 2025
7 checks passed

yejianquan added Request for 202505 Branch Approved for 202505 Branch labels Aug 19, 2025

mssonicbld mentioned this pull request Aug 19, 2025

[action] [PR:3788] Switchport mode update for 'show interfaces status' #4035

Merged

mssonicbld added the Created PR to 202505 Branch label Aug 19, 2025

mssonicbld added Included in 202505 Branch and removed Created PR to 202505 Branch labels Aug 20, 2025

	os.environ['UTILITIES_UNIT_TESTING'] = "2"
	os.environ['UTILITIES_UNIT_TESTING'] = UNIT_TESTING_MODE_ENABLED

Conversation

cshivashgit commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

mssonicbld commented Feb 27, 2025

Uh oh!

linux-foundation-easycla bot commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

cshivashgit commented Feb 28, 2025

Uh oh!

Uh oh!

wen587 commented Mar 11, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

cshivashgit commented Jun 6, 2025

Uh oh!

wsycqyz left a comment

Choose a reason for hiding this comment

Uh oh!

vrajeshe commented Jul 1, 2025

Uh oh!

vrajeshe commented Jul 10, 2025

Uh oh!

vrajeshe commented Jul 17, 2025

Uh oh!

vrajeshe commented Jul 18, 2025

Uh oh!

prsunny commented Jul 18, 2025

Uh oh!

cshivashgit commented Jul 20, 2025

Uh oh!

FengPan-Frank left a comment

Choose a reason for hiding this comment

Uh oh!

prsunny commented Jul 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jul 22, 2025

Uh oh!

azure-pipelines bot commented Jul 22, 2025

Uh oh!

mssonicbld commented Jul 22, 2025

Uh oh!

azure-pipelines bot commented Jul 22, 2025

Uh oh!

Uh oh!

cshivashgit commented Jul 24, 2025

Uh oh!

cshivashgit commented Feb 27, 2025 •

edited

Loading

linux-foundation-easycla bot commented Feb 27, 2025 •

edited

Loading