Fix the interface name length validation for subinterface#3774
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Mar 2, 2025
Merged
Fix the interface name length validation for subinterface#3774liat-grozovik merged 2 commits intosonic-net:masterfrom
liat-grozovik merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
force-pushed
the
sub_intf_fix
branch
from
85ae252 to
433a3ec
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
approved these changes
Feb 28, 2025
liat-grozovik
approved these changes
Mar 2, 2025
liat-grozovik
changed the title
Collaborator
|
Cherry-pick PR to 202411: #3799 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
…3774) - What I did Subinterface name length validation validates only the interface alias and not the entire subinterface name. This will result in wrong validation. - How I did it Fixed the validation to use subinterface name and not just interface alias. - How to verify it Added test case to verify.
shihhsien-wang
pushed a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Jan 21, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Jan 22, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Jan 22, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Jan 28, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Feb 2, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Feb 3, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Feb 3, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
shihhsien-wang
added a commit
to shihhsien-wang/sonic-utilities
that referenced
this pull request
Feb 3, 2026
…nic-net#3774)" This reverts commit 8fdea8d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Subinterface name length validation validates only the interface alias and not the entire subinterface name. This will result in wrong validation.
How I did it
Fixed the validation to use subinterface name and not just interface alias.
How to verify it
Added test case to verify.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)